New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(nms): Merging administration tools into nms #12402
Conversation
Thanks for opening a PR! 💯
Howto
More infoPlease take a moment to read through the Magma project's
If this is your first Magma PR, also consider reading
|
daf0d4e
to
055a349
Compare
5106de0
to
2af1673
Compare
c7d3dc0
to
50e0484
Compare
50e0484
to
4f51be9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! Could you just add a comment about isOrganizations
, before I merge this?
There are some refactoring/cleanup type changes that have been included in the PR here. I would prefer that those types of changes are put in a separate commit (or even PR) whenever possible.
4f51be9
to
c47ad75
Compare
Move administration and password settings from separate tab into main UI. Signed-off-by: Thomas Schmitt <thomas.schmitt@tngtech.com>
c47ad75
to
8ef614f
Compare
Move administration and password settings from separate tab into main UI. Signed-off-by: Thomas Schmitt <thomas.schmitt@tngtech.com>
Summary
Move administration and password settings from separate tab into main UI.
Fixes: #11543
Details
The administration page has been moved into the network specific UI thus the URL scheme has been changed to
/nms/<networkID>/admin/...
. If the admin page is selected the account menu button will be highlighted as suggested in the mockup. The new design for the button, menu and the account settings page itself are done as a separate PR #12430.The form to change the password was previously on the admin page but did not have a sidebar entry. Now it is a separate page under
/nms/<networkID>/settings
.If no network exists one still needs to be able to get to the admin and account settings page. Therefore in this special case the pages can still be reached under
/admin/...
and/settings
without the network related entries in the sidebar.The account settings are also available on the organizations page.
Testplan
Open the administration page as:
Open the account settings page: