Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs(agw): update network probe documentation #12403

Merged
merged 6 commits into from Apr 22, 2022
Merged

docs(agw): update network probe documentation #12403

merged 6 commits into from Apr 22, 2022

Conversation

ymasmoudi
Copy link
Collaborator

Signed-off-by: YOUSSEF EL MASMOUDI ymasmoudi@fb.com

Summary

Update network probe (LI) feature documentation

Test Plan

Additional Information

@pull-request-size pull-request-size bot added the size/M Denotes a PR that changes 30-99 lines. label Apr 5, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Apr 5, 2022

Thanks for opening a PR! 💯

A couple initial guidelines

Howto

  • Reviews. The "Reviewers" listed for this PR are the Magma maintainers who will shepherd it.
  • Checks. All required CI checks must pass before merge.
  • Merge. Once approved and passing CI checks, use the ready2merge label to indicate the maintainers can merge your PR.

More info

Please take a moment to read through the Magma project's

If this is your first Magma PR, also consider reading

@github-actions github-actions bot added the component: docs Documentation-related issue label Apr 5, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Apr 5, 2022 •
edited

Oops! Looks like you failed the Markdown lint check.

Howto

♻️ Updated: ✅ The check is passing the Markdown lint check after the last commit.

@pull-request-size pull-request-size bot added size/L Denotes a Pull Request that changes 100-499 lines. and removed size/M Denotes a PR that changes 30-99 lines. labels Apr 5, 2022
@ymasmoudi ymasmoudi force-pushed the agw_nprobe_documentation branch 3 times, most recently from cecbfa2 to 44e009f Compare April 5, 2022 21:10
@pull-request-size pull-request-size bot added size/M Denotes a PR that changes 30-99 lines. and removed size/L Denotes a Pull Request that changes 100-499 lines. labels Apr 5, 2022
@ymasmoudi ymasmoudi marked this pull request as ready for review April 5, 2022 21:56
@ymasmoudi ymasmoudi requested review from a team and electronjoe April 5, 2022 21:56
Neudrino
Neudrino reviewed Apr 6, 2022
View reviewed changes
docs/readmes/howtos/network_probe.md Outdated Show resolved Hide resolved
docs/readmes/howtos/network_probe.md Outdated Show resolved Hide resolved
docs/readmes/howtos/network_probe.md Outdated Show resolved Hide resolved
docs/readmes/howtos/network_probe.md Outdated Show resolved Hide resolved
docs/readmes/howtos/network_probe.md Outdated Show resolved Hide resolved
docs/readmes/howtos/network_probe.md Outdated Show resolved Hide resolved
docs/readmes/howtos/network_probe.md Outdated Show resolved Hide resolved
docs/readmes/howtos/network_probe.md Outdated Show resolved Hide resolved
docs/readmes/howtos/network_probe.md Outdated Show resolved Hide resolved
docs/readmes/howtos/network_probe.md Outdated Show resolved Hide resolved
@pull-request-size pull-request-size bot added size/L Denotes a Pull Request that changes 100-499 lines. and removed size/M Denotes a PR that changes 30-99 lines. labels Apr 6, 2022
@ymasmoudi ymasmoudi requested a review from Neudrino April 6, 2022 17:38
Neudrino
Neudrino reviewed Apr 7, 2022
View reviewed changes
docs/readmes/howtos/network_probe.md Outdated Show resolved Hide resolved
docs/readmes/howtos/network_probe.md Outdated Show resolved Hide resolved
docs/readmes/howtos/network_probe.md Outdated Show resolved Hide resolved
@ymasmoudi ymasmoudi closed this Apr 7, 2022
@Neudrino
Copy link
Contributor

Neudrino commented Apr 7, 2022

Hi @ymasmoudi ,
any reason this was closed?
This is in general a good contribution and only needs some small styling improvements.

@ymasmoudi ymasmoudi reopened this Apr 15, 2022
@ymasmoudi ymasmoudi force-pushed the agw_nprobe_documentation branch 2 times, most recently from ffffcef to 3d95016 Compare April 15, 2022 22:07
@ymasmoudi ymasmoudi requested a review from Neudrino April 15, 2022 22:08
@ymasmoudi
docs(agw): update network probe documentation
948b1c2 
Signed-off-by: YOUSSEF EL MASMOUDI <ymasmoudi@fb.com>
@ymasmoudi
docs(agw): update docusaurus
36dc31c 
Signed-off-by: YOUSSEF EL MASMOUDI <ymasmoudi@fb.com>
@ymasmoudi
docs(agw): add small fixes
7463efd 
Signed-off-by: YOUSSEF EL MASMOUDI <ymasmoudi@fb.com>
@ymasmoudi
fix review comments
3b674e1 
Signed-off-by: YOUSSEF EL MASMOUDI <ymasmoudi@fb.com>
@ymasmoudi
docs(agw): remove mention to nprobe-proxy
d4ae8a5 
Signed-off-by: YOUSSEF EL MASMOUDI <ymasmoudi@fb.com>
@ymasmoudi
remove extra space
b0856bf 
Signed-off-by: YOUSSEF EL MASMOUDI <ymasmoudi@fb.com>
@ymasmoudi ymasmoudi requested a review from Neudrino April 22, 2022 14:13
@ymasmoudi ymasmoudi merged commit 6a4ec3a into magma:master Apr 22, 2022
emakeev pushed a commit to emakeev/magma that referenced this pull request Aug 5, 2022
@ymasmoudi @emakeev
docs(agw): update network probe documentation (magma#12403)
cd45dff 
* docs(agw): update network probe documentation

Signed-off-by: YOUSSEF EL MASMOUDI <ymasmoudi@fb.com>

* docs(agw): update docusaurus

Signed-off-by: YOUSSEF EL MASMOUDI <ymasmoudi@fb.com>

* docs(agw): add small fixes

Signed-off-by: YOUSSEF EL MASMOUDI <ymasmoudi@fb.com>

* fix review comments

Signed-off-by: YOUSSEF EL MASMOUDI <ymasmoudi@fb.com>

* docs(agw): remove mention to nprobe-proxy

Signed-off-by: YOUSSEF EL MASMOUDI <ymasmoudi@fb.com>

* remove extra space

Signed-off-by: YOUSSEF EL MASMOUDI <ymasmoudi@fb.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Neudrino Neudrino Neudrino approved these changes

@electronjoe electronjoe Awaiting requested review from electronjoe

Assignees
No one assigned
Labels
component: docs Documentation-related issue size/L Denotes a Pull Request that changes 100-499 lines.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ymasmoudi @Neudrino