feat: Add support for grpc configuration for mock HSS at federated integ test #12406
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pull-request-size
bot
added
the
size/L
|
Thanks for opening a PR! 💯
Howto
More infoPlease take a moment to read through the Magma project's
If this is your first Magma PR, also consider reading
|
github-actions
bot
added
component: agw
uri200
force-pushed
the
s1aptest_add_support_for_grpc_hss_remote_config
branch
from
d93b400
to
20585df
Compare
|
Oops! Looks like you failed the Howto
♻️ Updated: ✅ The check is passing the Python Format Check after the last commit. |
| from lte.protos.subscriberdb_pb2 import ( | ||
| LTESubscription, | ||
| SubscriberData, | ||
| SubscriberID, | ||
| SubscriberState, | ||
| SubscriberUpdate, | ||
| ) | ||
| from feg.protos.hss_service_pb2_grpc import ( |
There was a problem hiding this comment.
While we import single class Parenthesis not needed.
| @@ -18,14 +18,17 @@ | |||
| import time | |||
|
|
|||
| import grpc | |||
| from integ_tests.gateway.rpc import get_gateway_hw_id, get_rpc_channel | |||
| from integ_tests.gateway.rpc import get_gateway_hw_id, get_rpc_channel, get_hss_rpc_channel | |||
There was a problem hiding this comment.
There was a Python format check complains about order of import statements, please follow as it suggested.
| # | ||
| # | ||
| # Sample configuration | ||
| #subscribers: |
There was a problem hiding this comment.
Please add a space between # and comment as linter suggested.
themarwhal
approved these changes
Apr 25, 2022
uri200
force-pushed
the
s1aptest_add_support_for_grpc_hss_remote_config
branch
from
20585df
to
c40e1a6
Compare
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
uri200
force-pushed
the
s1aptest_add_support_for_grpc_hss_remote_config
branch
3 times, most recently
from
c101701
to
ae1511f
Compare
GANESH-WAVELABS
approved these changes
May 2, 2022
uri200
changed the title
ardzoht
approved these changes
May 3, 2022
| """ | ||
|
|
||
| def __init__(self): | ||
| def __init__(self, grpcStub): |
There was a problem hiding this comment.
Suggested change
| def __init__(self, grpcStub): | |
| def __init__(self, grpc_stub): |
…teg test Signed-off-by: Oriol Batalla <obatalla@fb.com>
uri200
force-pushed
the
s1aptest_add_support_for_grpc_hss_remote_config
branch
from
ae1511f
to
1821e48
Compare
emakeev
pushed a commit
to emakeev/magma
that referenced
this pull request
Aug 5, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…teg test
Signed-off-by: Oriol Batalla obatalla@fb.com
Summary
This PR adds support to configure mock HSS running on FEG through s1aptestr.
We had to subclass SubscriberDBGrpc object to be able to use it with either a subscriberDB grpc stub or with a mock HSS grpc stub.
Note this PR depends on #12391, #12387, #12345 (and part of this issue #11338)
Note this framework can be used to add support to configure mock PCRF and mock OCS we have on magma testcore
Test Plan
This log below shows the federated test running using mock hss. In that case the HSS is configured with two subscribers, updated with specific APN. Subscriber db remains unconfigured for this case
The second log shows how HSS is configured with those subscribers.
Third log shows
s6a_proxyrunning on that setup showing authentication messages comming from HSSmock hss grpc log
s6a_proxy log showing authentication AVP and grpc protos
Additional Information