Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(dp): Fix requests migration #12411

Merged
merged 1 commit into from Apr 6, 2022
Merged

fix(dp): Fix requests migration #12411

merged 1 commit into from Apr 6, 2022

Conversation

jkmar
Copy link
Contributor

@jkmar jkmar commented Apr 6, 2022

Summary

Migration generated by alembic was wrong, since it tried to
delete table when it was still referenced as foreign key.

Signed-off-by: Kuba Marciniszyn kuba@freedomfi.com

Migration generated by alembic was wrong, since it tried to
delete table when it was still referenced as foreign key.

Signed-off-by: Kuba Marciniszyn <kuba@freedomfi.com>
@jkmar jkmar requested review from a team and xbend April 6, 2022 10:36
@pull-request-size pull-request-size bot added the size/XS Denotes a PR that changes 0-9 lines. label Apr 6, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Apr 6, 2022

Thanks for opening a PR! 💯

A couple initial guidelines

Howto

  • Reviews. The "Reviewers" listed for this PR are the Magma maintainers who will shepherd it.
  • Checks. All required CI checks must pass before merge.
  • Merge. Once approved and passing CI checks, use the ready2merge label to indicate the maintainers can merge your PR.

More info

Please take a moment to read through the Magma project's

If this is your first Magma PR, also consider reading

Copy link
Contributor

@xbend xbend left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jkmar jkmar merged commit d4b22d0 into magma:master Apr 6, 2022
@jkmar jkmar deleted the fix_migration branch April 6, 2022 11:59
@github-actions
Copy link
Contributor

github-actions bot commented Apr 6, 2022

Unit Test Results

157 files  157 suites   2h 3m 40s ⏱️
308 tests 305 ✔️ 3 💤 0

Results for commit d4b22d0.

♻️ This comment has been updated with latest results.

emakeev pushed a commit to emakeev/magma that referenced this pull request Aug 5, 2022
Migration generated by alembic was wrong, since it tried to
delete table when it was still referenced as foreign key.

Signed-off-by: Kuba Marciniszyn <kuba@freedomfi.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/XS Denotes a PR that changes 0-9 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants