Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ci): operator docker image artifactory push fix master branch #12412

Conversation

ShubhamTatvamasi
Copy link
Contributor

@ShubhamTatvamasi ShubhamTatvamasi commented Apr 6, 2022

Signed-off-by: Shubham Tatvamasi shubhamtatvamasi@gmail.com

Summary

Same operator docker image CI fix.

https://github.com/magma/magma/pull/12377/files
https://github.com/magma/magma/pull/12412/files

Test Plan

Additional Information

  • This change is backwards-breaking

@ShubhamTatvamasi ShubhamTatvamasi requested a review from a team as a code owner April 6, 2022 10:43
@pull-request-size pull-request-size bot added the size/XS Denotes a PR that changes 0-9 lines. label Apr 6, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Apr 6, 2022

Thanks for opening a PR! 💯

A couple initial guidelines

Howto

  • Reviews. The "Reviewers" listed for this PR are the Magma maintainers who will shepherd it.
  • Checks. All required CI checks must pass before merge.
  • Merge. Once approved and passing CI checks, use the ready2merge label to indicate the maintainers can merge your PR.

More info

Please take a moment to read through the Magma project's

If this is your first Magma PR, also consider reading

@github-actions github-actions bot added the component: ci All updates on CI (Jenkins/CircleCi/Github Action) label Apr 6, 2022
Copy link
Contributor

@Neudrino Neudrino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is the PR intentionally against master?
I would expect for master the implementation is correct as is?

@ShubhamTatvamasi
Copy link
Contributor Author

Is the PR intentionally against master? I would expect for master the implementation is correct as is?

Yes, we just don't want the same to happen with v1.8 that why this PR is needed.

Copy link
Contributor

@Neudrino Neudrino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the explanation. And the restriction master or release branch will be the one from the workflow itself, such that we still avoid artifacts from PRs being pushed, afaiks.

@ShubhamTatvamasi ShubhamTatvamasi enabled auto-merge (squash) April 20, 2022 09:47
@ShubhamTatvamasi ShubhamTatvamasi force-pushed the artifactory-push-fix-operator-docker-image branch from ed9eaf9 to 0337304 Compare April 20, 2022 09:48
Signed-off-by: Shubham Tatvamasi <shubhamtatvamasi@gmail.com>
@ShubhamTatvamasi ShubhamTatvamasi force-pushed the artifactory-push-fix-operator-docker-image branch from 0337304 to a91b767 Compare April 30, 2022 05:39
@ShubhamTatvamasi ShubhamTatvamasi merged commit 97b8495 into magma:master Apr 30, 2022
emakeev pushed a commit to emakeev/magma that referenced this pull request Aug 5, 2022
…gma#12412)

Signed-off-by: Shubham Tatvamasi <shubhamtatvamasi@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: ci All updates on CI (Jenkins/CircleCi/Github Action) size/XS Denotes a PR that changes 0-9 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants