New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(ci): operator docker image artifactory push fix master branch #12412
fix(ci): operator docker image artifactory push fix master branch #12412
Conversation
Thanks for opening a PR! 💯
Howto
More infoPlease take a moment to read through the Magma project's
If this is your first Magma PR, also consider reading
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is the PR intentionally against master
?
I would expect for master
the implementation is correct as is?
Yes, we just don't want the same to happen with |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the explanation. And the restriction master or release branch will be the one from the workflow itself, such that we still avoid artifacts from PRs being pushed, afaiks.
ed9eaf9
to
0337304
Compare
Signed-off-by: Shubham Tatvamasi <shubhamtatvamasi@gmail.com>
0337304
to
a91b767
Compare
…gma#12412) Signed-off-by: Shubham Tatvamasi <shubhamtatvamasi@gmail.com>
Signed-off-by: Shubham Tatvamasi shubhamtatvamasi@gmail.com
Summary
Same operator docker image CI fix.
https://github.com/magma/magma/pull/12377/files
https://github.com/magma/magma/pull/12412/files
Test Plan
Additional Information