feat(mme): NGAP Reset ALL #12451
Merged
feat(mme): NGAP Reset ALL #12451
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pull-request-size
bot
added
the
size/XL
|
Thanks for opening a PR! 💯
Howto
More infoPlease take a moment to read through the Magma project's
If this is your first Magma PR, also consider reading
|
|
Oops! Looks like you failed the Howto
♻️ Updated: ✅ The check is passing the Semantic PR after the last commit. |
aniket021997
force-pushed
the
topic/aniket/ngap_reset_all
branch
from
713f5dc
to
3f156fb
Compare
aniket021997
force-pushed
the
topic/aniket/ngap_reset_all
branch
3 times, most recently
from
da6eba9
to
4f4f133
Compare
aniket021997
force-pushed
the
topic/aniket/ngap_reset_all
branch
from
4f4f133
to
7f8c87b
Compare
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| @@ -298,6 +298,10 @@ void itti_free_msg_content(MessageDef* const message_p) { | |||
| bdestroy_wrapper(&pdusession_resource_setup_req->nas_pdu); | |||
| break; | |||
| } | |||
| case NGAP_GNB_INITIATED_RESET_REQ: | |||
| free_wrapper((void**)&message_p->ittiMsg.ngap_gnb_initiated_reset_req | |||
There was a problem hiding this comment.
[cpplint] reported by reviewdog 🐶
Using C-style cast. Use reinterpret_cast<void**>(...) instead [readability/casting] [4]
| const uint64_t dataP, void* argP, | ||
| void** resultP) { | ||
| arg_ngap_construct_gnb_reset_req_t* arg = argP; | ||
| m5g_ue_description_t* ue_ref = (m5g_ue_description_t*)dataP; |
There was a problem hiding this comment.
[cpplint] reported by reviewdog 🐶
Using C-style cast. Use reinterpret_cast<m5g_ue_description_t*>(...) instead [readability/casting] [4]
| m5g_ue_description_t* ue_ref = (m5g_ue_description_t*)dataP; | ||
|
|
||
| hash_table_ts_t* ng_ue_state = get_ngap_ue_state(); | ||
| hashtable_ts_get(ng_ue_state, (const hash_key_t)dataP, (void**)&ue_ref); |
There was a problem hiding this comment.
[cpplint] reported by reviewdog 🐶
Using C-style cast. Use reinterpret_cast<void**>(...) instead [readability/casting] [4]
| increment_counter("NG_reset_from_gnb", 1, 1, "action", "reset_ack_sent"); | ||
| if (buffer) { | ||
| bstring b = blk2bstr(buffer, length); | ||
| free_wrapper((void**)&buffer); |
There was a problem hiding this comment.
[cpplint] reported by reviewdog 🐶
Using C-style cast. Use reinterpret_cast<void**>(...) instead [readability/casting] [4]
aniket021997
force-pushed
the
topic/aniket/ngap_reset_all
branch
from
7f8c87b
to
59fd8cd
Compare
aniket021997
force-pushed
the
topic/aniket/ngap_reset_all
branch
from
59fd8cd
to
6a1410b
Compare
aniket021997
force-pushed
the
topic/aniket/ngap_reset_all
branch
from
6a1410b
to
1ee4517
Compare
aniket021997
force-pushed
the
topic/aniket/ngap_reset_all
branch
from
1ee4517
to
97d2af4
Compare
aniket021997
force-pushed
the
topic/aniket/ngap_reset_all
branch
3 times, most recently
from
685979c
to
690b033
Compare
feat(ngap): NGAP Reset ALL Signed-off-by: aniket021997 <aniket.sonawane@wavelabs.ai> rebased ngap reset all Signed-off-by: aniket021997 <aniket.sonawane@wavelabs.ai> ng reset all - rebased and imrpoved loggings Signed-off-by: aniket021997 <aniket.sonawane@wavelabs.ai>
aniket021997
force-pushed
the
topic/aniket/ngap_reset_all
branch
from
690b033
to
46c1ec9
Compare
emakeev
pushed a commit
to emakeev/magma
that referenced
this pull request
Aug 5, 2022
feat(ngap): NGAP Reset ALL Signed-off-by: aniket021997 <aniket.sonawane@wavelabs.ai> rebased ngap reset all Signed-off-by: aniket021997 <aniket.sonawane@wavelabs.ai> ng reset all - rebased and imrpoved loggings Signed-off-by: aniket021997 <aniket.sonawane@wavelabs.ai>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: aniket021997 aniket.sonawane@wavelabs.ai
Summary
Test Plan
Validated with UT.
Basic Sanity with UERANSIM
PCAP snap:
NG Reset-All Pcap from TeraVM with acknowledgement
mme log:
mme.log
Additional Information