Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(enodebd): Baicells QRTB firmware upgrade #12454

Merged
merged 1 commit into from Apr 14, 2022

Conversation

xbend
Copy link
Contributor

@xbend xbend commented Apr 13, 2022

Added TR069 firmware upgrade support for Baicells running QRTB firmware.

Signed-off-by: Artur Dębski artur.debski@freedomfi.com

Summary

  • Extended QRTB device model with Firmware Upgrade Download flow states

Test Plan

Tested on Baicells Neutrino430 BS with QRTB Firmwares 2.7.X and 2.8.X in a staging environment.

Additional Information

  • This change is backwards-breaking

@xbend xbend requested a review from a team April 13, 2022 10:14
@xbend xbend requested a review from a team as a code owner April 13, 2022 10:14
@xbend xbend requested a review from sebathomas April 13, 2022 10:14
@pull-request-size pull-request-size bot added the size/L Denotes a Pull Request that changes 100-499 lines. label Apr 13, 2022
@github-actions
Copy link
Contributor

Thanks for opening a PR! 💯

A couple initial guidelines

Howto

  • Reviews. The "Reviewers" listed for this PR are the Magma maintainers who will shepherd it.
  • Checks. All required CI checks must pass before merge.
  • Merge. Once approved and passing CI checks, use the ready2merge label to indicate the maintainers can merge your PR.

More info

Please take a moment to read through the Magma project's

If this is your first Magma PR, also consider reading

@github-actions github-actions bot added the component: agw Access gateway-related issue label Apr 13, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Apr 13, 2022

feg-workflow

    2 files  202 suites   38s ⏱️
370 tests 370 ✔️ 0 💤 0
384 runs  384 ✔️ 0 💤 0

Results for commit 56f6215.

♻️ This comment has been updated with latest results.

@github-actions
Copy link
Contributor

github-actions bot commented Apr 13, 2022

agw-workflow

     77 files     122 suites   6m 42s ⏱️
1 149 tests 1 140 ✔️ 9 💤 0
1 150 runs  1 141 ✔️ 9 💤 0

Results for commit 56f6215.

♻️ This comment has been updated with latest results.

@xbend xbend force-pushed the enodebd_baicells_qrtb_fw_upgrade branch from de46bec to 26965b8 Compare April 13, 2022 13:58
@xbend xbend requested review from a team and electronjoe April 13, 2022 13:58
@electronjoe electronjoe requested review from LKreutzer and removed request for electronjoe April 13, 2022 14:19
@xbend xbend force-pushed the enodebd_baicells_qrtb_fw_upgrade branch from 26965b8 to 10bcfbf Compare April 13, 2022 14:37
Copy link
Contributor

@ardzoht ardzoht left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lte/gateway changes lgtm

@nstng nstng requested review from nstng and removed request for LKreutzer April 13, 2022 15:14
@xbend
Copy link
Contributor Author

xbend commented Apr 13, 2022

Fixed bazel CI. CI is now passing. Just waiting for bazel and python approvals @sebathomas @nstng

Copy link
Contributor

@nstng nstng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bazel change looks good modulo unneeded dependencies. Tested service and tests on vm and devcontainer. Feel free to drop a line in #bazel if you have more questions :)

lte/gateway/python/magma/enodebd/tests/BUILD.bazel Outdated Show resolved Hide resolved
Added TR069 firmware upgrade support for Baicells running QRTB firmware.

Signed-off-by: Artur Dębski <artur.debski@freedomfi.com>
@xbend xbend force-pushed the enodebd_baicells_qrtb_fw_upgrade branch from 10bcfbf to 56f6215 Compare April 14, 2022 09:36
@nstng nstng self-requested a review April 14, 2022 09:56
Copy link
Contributor

@nstng nstng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for addressing the change requests - Bazel changes LGTM

@sebathomas sebathomas removed their request for review April 14, 2022 10:02
@xbend xbend merged commit 5c247df into magma:master Apr 14, 2022
@xbend xbend deleted the enodebd_baicells_qrtb_fw_upgrade branch April 14, 2022 13:59
emakeev pushed a commit to emakeev/magma that referenced this pull request Aug 5, 2022
Added TR069 firmware upgrade support for Baicells running QRTB firmware.

Signed-off-by: Artur Dębski <artur.debski@freedomfi.com>

Co-authored-by: Artur Dębski <artur.debski@freedomfi.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: agw Access gateway-related issue size/L Denotes a Pull Request that changes 100-499 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants