Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(agw): Provides the fixes for the issue #12364 #12474

Merged
merged 2 commits into from May 12, 2022

Conversation

rsarwad
Copy link
Contributor

@rsarwad rsarwad commented Apr 14, 2022

Signed-off-by: Rashmi rashmi.sarwad@radisys.com

Summary

Modified code to

  1. Fixes the issue, grpc_async_service_thread : Fatal Error: SIGABRT / SI_TKILL in Non-Nat #12364
  2. Stop the async grpc server as part of itti task termination
  3. During completion queue shutdown, pop out all messages from completion queue and free the allocated resources

Test Plan

Executed s1ap sanity test suite, unit test cases and s6a test cases in Teravm setup configured for both NAT enabled and disabled

@rsarwad rsarwad requested review from a team and ssanadhya April 14, 2022 14:45
@pull-request-size pull-request-size bot added the size/M Denotes a PR that changes 30-99 lines. label Apr 14, 2022
@github-actions github-actions bot added the component: agw Access gateway-related issue label Apr 14, 2022
@github-actions
Copy link
Contributor

Thanks for opening a PR! 💯

A couple initial guidelines

Howto

  • Reviews. The "Reviewers" listed for this PR are the Magma maintainers who will shepherd it.
  • Checks. All required CI checks must pass before merge.
  • Merge. Once approved and passing CI checks, use the ready2merge label to indicate the maintainers can merge your PR.

More info

Please take a moment to read through the Magma project's

If this is your first Magma PR, also consider reading

@github-actions
Copy link
Contributor

github-actions bot commented Apr 14, 2022

feg-workflow

    2 files  202 suites   38s ⏱️
370 tests 370 ✔️ 0 💤 0
384 runs  384 ✔️ 0 💤 0

Results for commit 70900fb.

♻️ This comment has been updated with latest results.

Signed-off-by: Rashmi <rashmi.sarwad@radisys.com>
@github-actions
Copy link
Contributor

github-actions bot commented Apr 14, 2022

agw-workflow

     77 files     122 suites   7m 18s ⏱️
1 149 tests 1 140 ✔️ 9 💤 0
1 150 runs  1 141 ✔️ 9 💤 0

Results for commit 70900fb.

♻️ This comment has been updated with latest results.

…2364

Signed-off-by: Rashmi <rashmi.sarwad@radisys.com>
Copy link
Collaborator

@ssanadhya ssanadhya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@Neudrino Neudrino changed the title fix(agw): Provides the fixes for the issue 1264 fix(agw): Provides the fixes for the issue #12364 Apr 26, 2022
@ssanadhya ssanadhya merged commit c4b87d9 into magma:master May 12, 2022
emakeev pushed a commit to emakeev/magma that referenced this pull request Aug 5, 2022
Signed-off-by: Rashmi <rashmi.sarwad@radisys.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: agw Access gateway-related issue size/M Denotes a PR that changes 30-99 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

grpc_async_service_thread : Fatal Error: SIGABRT / SI_TKILL in Non-Nat
2 participants