Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(dp): Require explicit join #12479

Merged
merged 1 commit into from Apr 15, 2022
Merged

chore(dp): Require explicit join #12479

merged 1 commit into from Apr 15, 2022

Conversation

jkmar
Copy link
Contributor

@jkmar jkmar commented Apr 15, 2022

Summary

Previously joins were done implicitly, but it didn't work
when there were multiple relations to the same table.
Now join no longer is deduced and has to be specified manually.

Signed-off-by: Kuba Marciniszyn kuba@freedomfi.com

Previously joins were done implicitly, but it didn't work
when there were multiple relations to the same table.
Now join no longer is deduced and has to be specified manually.

Signed-off-by: Kuba Marciniszyn <kuba@freedomfi.com>
@jkmar jkmar requested review from xbend, WojSad and a team April 15, 2022 11:25
@pull-request-size pull-request-size bot added the size/M Denotes a PR that changes 30-99 lines. label Apr 15, 2022
@github-actions
Copy link
Contributor

Thanks for opening a PR! 💯

A couple initial guidelines

Howto

  • Reviews. The "Reviewers" listed for this PR are the Magma maintainers who will shepherd it.
  • Checks. All required CI checks must pass before merge.
  • Merge. Once approved and passing CI checks, use the ready2merge label to indicate the maintainers can merge your PR.

More info

Please take a moment to read through the Magma project's

If this is your first Magma PR, also consider reading

@jkmar jkmar merged commit 22e7bef into magma:master Apr 15, 2022
@jkmar jkmar deleted the explicit_join branch April 15, 2022 12:18
emakeev pushed a commit to emakeev/magma that referenced this pull request Aug 5, 2022
Previously joins were done implicitly, but it didn't work
when there were multiple relations to the same table.
Now join no longer is deduced and has to be specified manually.

Signed-off-by: Kuba Marciniszyn <kuba@freedomfi.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/M Denotes a PR that changes 30-99 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants