New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(nms): Consolidate text components #12502
Merged
thmsschmitt
merged 1 commit into
magma:master
from
thmsschmitt:consolidate-text-components
Apr 28, 2022
Merged
refactor(nms): Consolidate text components #12502
thmsschmitt
merged 1 commit into
magma:master
from
thmsschmitt:consolidate-text-components
Apr 28, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pull-request-size
bot
added
the
size/XXL
Denotes a Pull Request that changes 1000+ lines.
label
Apr 20, 2022
Thanks for opening a PR! 💯
Howto
More infoPlease take a moment to read through the Magma project's
If this is your first Magma PR, also consider reading
|
github-actions
bot
added
component: ci
All updates on CI (Jenkins/CircleCi/Github Action)
component: docs
Documentation-related issue
component: nms
NMS-related issue
labels
Apr 20, 2022
Remove text compoment that uses symphony theme and replace its usages. Signed-off-by: Thomas Schmitt <thomas.schmitt@tngtech.com>
thmsschmitt
force-pushed
the
consolidate-text-components
branch
from
April 28, 2022 11:50
a297380
to
2bbc812
Compare
pull-request-size
bot
added
size/L
Denotes a Pull Request that changes 100-499 lines.
and removed
size/XXL
Denotes a Pull Request that changes 1000+ lines.
labels
Apr 28, 2022
github-actions
bot
removed
component: ci
All updates on CI (Jenkins/CircleCi/Github Action)
component: docs
Documentation-related issue
labels
Apr 28, 2022
HannaFar
approved these changes
Apr 28, 2022
emakeev
pushed a commit
to emakeev/magma
that referenced
this pull request
Aug 5, 2022
Remove text compoment that uses symphony theme and replace its usages. Signed-off-by: Thomas Schmitt <thomas.schmitt@tngtech.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Two almost identical Text components were used across the app. The only extra feature that the
fbc_js_core
Text has was not used. I've consolidated this to only use the NMS Text component.Tests