Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(nms): Consolidate text components #12502

Merged
merged 1 commit into from Apr 28, 2022

Conversation

thmsschmitt
Copy link
Contributor

@thmsschmitt thmsschmitt commented Apr 20, 2022

Summary

Two almost identical Text components were used across the app. The only extra feature that the fbc_js_core Text has was not used. I've consolidated this to only use the NMS Text component.

Tests

$ yarn eslint .
...
✖ 199 problems (0 errors, 199 warnings)

✨  Done in 22.11s.

@pull-request-size pull-request-size bot added the size/XXL Denotes a Pull Request that changes 1000+ lines. label Apr 20, 2022
@github-actions
Copy link
Contributor

Thanks for opening a PR! 💯

A couple initial guidelines

Howto

  • Reviews. The "Reviewers" listed for this PR are the Magma maintainers who will shepherd it.
  • Checks. All required CI checks must pass before merge.
  • Merge. Once approved and passing CI checks, use the ready2merge label to indicate the maintainers can merge your PR.

More info

Please take a moment to read through the Magma project's

If this is your first Magma PR, also consider reading

@github-actions github-actions bot added component: ci All updates on CI (Jenkins/CircleCi/Github Action) component: docs Documentation-related issue component: nms NMS-related issue labels Apr 20, 2022
@github-actions
Copy link
Contributor

feg-workflow

    2 files  202 suites   39s ⏱️
370 tests 370 ✔️ 0 💤 0
384 runs  384 ✔️ 0 💤 0

Results for commit a297380.

@github-actions
Copy link
Contributor

github-actions bot commented Apr 20, 2022

nms-workflow

0 files  0 suites   0s ⏱️
0 tests 0 ✔️ 0 💤 0

Results for commit 2bbc812.

♻️ This comment has been updated with latest results.

@github-actions
Copy link
Contributor

cloud-workflow

    5 files  321 suites   2m 18s ⏱️
797 tests 797 ✔️ 0 💤 0

Results for commit a297380.

@github-actions
Copy link
Contributor

agw-workflow

     77 files     122 suites   7m 41s ⏱️
1 149 tests 1 140 ✔️ 9 💤 0
1 150 runs  1 141 ✔️ 9 💤 0

Results for commit a297380.

Remove text compoment that uses symphony theme and replace its usages.

Signed-off-by: Thomas Schmitt <thomas.schmitt@tngtech.com>
@pull-request-size pull-request-size bot added size/L Denotes a Pull Request that changes 100-499 lines. and removed size/XXL Denotes a Pull Request that changes 1000+ lines. labels Apr 28, 2022
@github-actions github-actions bot removed component: ci All updates on CI (Jenkins/CircleCi/Github Action) component: docs Documentation-related issue labels Apr 28, 2022
@thmsschmitt thmsschmitt marked this pull request as ready for review April 28, 2022 12:26
@thmsschmitt thmsschmitt requested review from a team and HannaFar April 28, 2022 12:26
@thmsschmitt thmsschmitt merged commit 2746e51 into magma:master Apr 28, 2022
emakeev pushed a commit to emakeev/magma that referenced this pull request Aug 5, 2022
Remove text compoment that uses symphony theme and replace its usages.

Signed-off-by: Thomas Schmitt <thomas.schmitt@tngtech.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: nms NMS-related issue size/L Denotes a Pull Request that changes 100-499 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants