Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(pipelined): QFI value Set in RYU #12514

Merged
merged 2 commits into from May 26, 2022
Merged

feat(pipelined): QFI value Set in RYU #12514

merged 2 commits into from May 26, 2022

Conversation

prabinakpattnaik
Copy link
Contributor

Signed-off-by: prabina pattnaik prabinak@wavelabs.ai

Summary

QFI value set in open-flow controller using RYU.
For QFI functionality support in OVS Datapath for GTP tunnel, following tasks are consider for it:

  1. QFI value set in MATCH criteria for Uplink flows
  2. QFI value set in ACTION criteria for Downlink flows

Test Plan

Additional Information

@prabinakpattnaik prabinakpattnaik requested a review from a team as a code owner April 20, 2022 19:26
@prabinakpattnaik prabinakpattnaik requested review from a team and ajahl April 20, 2022 19:26
@pull-request-size pull-request-size bot added the size/L Denotes a Pull Request that changes 100-499 lines. label Apr 20, 2022
@github-actions
Copy link
Contributor

Thanks for opening a PR! 💯

A couple initial guidelines

Howto

  • Reviews. The "Reviewers" listed for this PR are the Magma maintainers who will shepherd it.
  • Checks. All required CI checks must pass before merge.
  • Merge. Once approved and passing CI checks, use the ready2merge label to indicate the maintainers can merge your PR.

More info

Please take a moment to read through the Magma project's

If this is your first Magma PR, also consider reading

@github-actions github-actions bot added component: agw Access gateway-related issue component: orc8r Orchestrator-related issue labels Apr 20, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Apr 20, 2022 •
edited

Oops! Looks like you failed the Semantic PR check.

Howto

♻️ Updated: ✅ The check is passing the Semantic PR after the last commit.

@github-actions
Copy link
Contributor

github-actions bot commented Apr 20, 2022 •
edited

feg-workflow

    2 files  202 suites   38s ⏱️
371 tests 371 ✔️ 0 💤 0 ❌
385 runs  385 ✔️ 0 💤 0 ❌

Results for commit 87dce0f.

♻️ This comment has been updated with latest results.

@github-actions
Copy link
Contributor

github-actions bot commented Apr 20, 2022 •
edited

cloud-workflow

    7 files  354 suites   2m 12s ⏱️
949 tests 949 ✔️ 0 💤 0 ❌

Results for commit 87dce0f.

♻️ This comment has been updated with latest results.

@github-actions
Copy link
Contributor

github-actions bot commented Apr 20, 2022 •
edited

agw-workflow

     77 files     122 suites   6m 15s ⏱️
1 159 tests 1 155 ✔️ 4 💤 0 ❌
1 160 runs  1 156 ✔️ 4 💤 0 ❌

Results for commit 87dce0f.

♻️ This comment has been updated with latest results.

@nstng
Copy link
Contributor

nstng commented Apr 21, 2022

Hi, couple questions:

  1. We assume this change is in context of QFI support in OVS kernel #9452 (btw closed by stale bot) and https://docs.google.com/document/d/1vRdKNlTdifNMQ6p1ChUu9o872LNyEEqjZOby1j4SzzE/edit is this correct?
  2. Is there an overview of done and open tasks/issues for this effort?
  3. The current change seems not be used in production code - is this a preparation for a follow up PR?
  4. Were the sudo unit tests and integration tests executed on this change?
  5. We assume its currently necessary to patch ryu - was evaluated if there is a way to achieve the same by magma code? Patching an external dependency could make it hard to upgrade.
  6. The migrated bazel build of pipelined was just merged - i.e., after a rebase the patch needs to be applied there as well. We could do this in a follow-up PR.

@prabinakpattnaik prabinakpattnaik changed the title feat(RYU): QFI value Set in RYU feat(Pipelined): QFI value Set in RYU Apr 22, 2022
@prabinakpattnaik prabinakpattnaik mentioned this pull request Apr 22, 2022
Merged
@prabinakpattnaik
Copy link
Contributor Author

@nstng , sorry for late response.
Please find the my answers as below:
Yes, This is the basic design flows for support QFI in OVS kernel.
There are 3 PRs (OVS PR #10556[UT is present], Pipelined/Sessiond changes PR #12529 [End to end testing flow logs present] and this PR for RYU changes.]
Please go through these PRs and will get more clarity.

@prabinakpattnaik prabinakpattnaik changed the title feat(Pipelined): QFI value Set in RYU feat(pipelined): QFI value Set in RYU May 6, 2022
@netlify
Copy link

netlify bot commented May 19, 2022 •
edited

👷 Deploy request for competent-euler-513227 pending review.

Visit the deploys page to approve it

Name Link
🔨 Latest commit 852104d

@github-actions
Copy link
Contributor

github-actions bot commented May 19, 2022 •
edited

dp-workflow

  2 files    2 suites   3m 25s ⏱️
15 tests 15 ✔️ 0 💤 0 ❌

Results for commit 87dce0f.

♻️ This comment has been updated with latest results.

@prabinakpattnaik prabinakpattnaik force-pushed the RYU_QFI_Support branch 3 times, most recently from fe11ad5 to 852104d Compare May 20, 2022 18:11
@prabinakpattnaik
feat(RYU): QFI value Set in RYU
4fc9382 
Signed-off-by: prabina pattnaik <prabinak@wavelabs.ai>
@prabinakpattnaik
feat(Pipelined): QFI value Set in RYU
87dce0f 
Signed-off-by: prabina pattnaik <prabinak@wavelabs.ai>
@pshelar pshelar merged commit 48a000f into magma:master May 26, 2022
mpfirrmann pushed a commit to mpfirrmann/magma that referenced this pull request May 31, 2022
@prabinakpattnaik @mpfirrmann
feat(pipelined): QFI value Set in RYU (magma#12514)
b730007 
* feat(RYU): QFI value Set in RYU

Signed-off-by: prabina pattnaik <prabinak@wavelabs.ai>

* feat(Pipelined): QFI value Set in RYU

Signed-off-by: prabina pattnaik <prabinak@wavelabs.ai>
@nstng nstng mentioned this pull request Jul 27, 2022
Merged
1 task
emakeev pushed a commit to emakeev/magma that referenced this pull request Aug 5, 2022
@prabinakpattnaik @emakeev
feat(pipelined): QFI value Set in RYU (magma#12514)
827ea9f 
* feat(RYU): QFI value Set in RYU

Signed-off-by: prabina pattnaik <prabinak@wavelabs.ai>

* feat(Pipelined): QFI value Set in RYU

Signed-off-by: prabina pattnaik <prabinak@wavelabs.ai>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pshelar pshelar pshelar approved these changes

@ajahl ajahl Awaiting requested review from ajahl ajahl was automatically assigned from magma/approvers-agw

@uri200 uri200 Awaiting requested review from uri200

@koolzz koolzz Awaiting requested review from koolzz

@vikramgreddy vikramgreddy Awaiting requested review from vikramgreddy

@nstng nstng Awaiting requested review from nstng

Assignees
No one assigned
Labels
component: agw Access gateway-related issue component: orc8r Orchestrator-related issue size/L Denotes a Pull Request that changes 100-499 lines.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@prabinakpattnaik @nstng @pshelar