chore(orc8r): Switch Magma to proto V2 #12526
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pull-request-size
bot
added
the
size/XXL
|
Thanks for opening a PR! 💯
Howto
More infoPlease take a moment to read through the Magma project's
If this is your first Magma PR, also consider reading
|
github-actions
bot
added
component: ci
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
emakeev
force-pushed
the
go_proto_api_v2
branch
from
f37c06e
to
5ec3b53
Compare
emakeev
added
the
ready2merge
emakeev
force-pushed
the
go_proto_api_v2
branch
from
5ec3b53
to
80a41ab
Compare
github-actions
bot
removed
the
component: ci
emakeev
removed
the
ready2merge
|
@maxhbr, NP - just trying to help, I suggested to split 12151 a while back (#12151 (comment)) & wasn't sure if there were issues with such approach. |
emakeev
force-pushed
the
go_proto_api_v2
branch
2 times, most recently
from
e1691aa
to
9819ba6
Compare
Signed-off-by: Evgeniy Makeev <evgeniym@fb.com>
emakeev
force-pushed
the
go_proto_api_v2
branch
from
9819ba6
to
289c31c
Compare
6 tasks
|
I think, this PR has now been superseded by #12546 and should be closed. |
|
closing since #12546 has been successfully merged |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Evgeniy Makeev evgeniym@fb.com
Summary
Switch Magma to proto V2
There is an effort of upgrading Magma to Go 1.18 (#12151), it includes 3 significant changes to codebase:
Each of the mentioned above changes are very large, so - authors, mainteners and reviewers could benefit from compartmentalizing them in separate PRs. This PR is the implementation of #1 - proto upgrade.
The proto upgrade involves significant changes to some of magma core APIs as well as unit tests.
It makes sense to separate it, also - proto upgrade (or at least core of it) can be done independent of swagger & Go 1.18 upgrade.
The change provides proto V2 upgrade without over-reliance on relatively expensive proto clone calls.
The most significant required change is the modification of configurator APIs/interfaces which were erroneously designed to pass & return config structures by value, the rest of the changes are mostly related to unit tests.
Test Plan
fix & run unit tests
Additional Information