Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(dp): Move desired state from active mode config to cbsd #12538

Merged
merged 1 commit into from Apr 25, 2022

Conversation

jkmar
Copy link
Contributor

@jkmar jkmar commented Apr 22, 2022

Summary

Move desired state from active mode config to cbsd.
Also remove active mode config table.

Test Plan

Migrations tested manually, since we don't have automated migration tests yet.

Signed-off-by: Kuba Marciniszyn kuba@freedomfi.com

Also remove active mode config table.

Signed-off-by: Kuba Marciniszyn <kuba@freedomfi.com>
@jkmar jkmar requested review from xbend, WojSad and a team April 22, 2022 13:44
@pull-request-size pull-request-size bot added the size/L Denotes a Pull Request that changes 100-499 lines. label Apr 22, 2022
@github-actions
Copy link
Contributor

Thanks for opening a PR! 💯

A couple initial guidelines

Howto

  • Reviews. The "Reviewers" listed for this PR are the Magma maintainers who will shepherd it.
  • Checks. All required CI checks must pass before merge.
  • Merge. Once approved and passing CI checks, use the ready2merge label to indicate the maintainers can merge your PR.

More info

Please take a moment to read through the Magma project's

If this is your first Magma PR, also consider reading

@jkmar jkmar merged commit b09c06d into magma:master Apr 25, 2022
@jkmar jkmar deleted the move_desired_state_to_cbsd branch April 25, 2022 14:10
emakeev pushed a commit to emakeev/magma that referenced this pull request Aug 5, 2022
…12538)

Also remove active mode config table.

Signed-off-by: Kuba Marciniszyn <kuba@freedomfi.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/L Denotes a Pull Request that changes 100-499 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants