Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ci): Latest fixes from Eurecom Infrastructure changes #12570

Merged
merged 6 commits into from Apr 28, 2022

Conversation

rdefosse
Copy link
Contributor

Summary

This month (April 2022), our hosting partner (Eurecom) did a major network infrastructure upgrade. We had to modify a few things in the pipeline scripts:

  • There is no more need for a git proxy in this new network
  • the git fetch --unshallow was made because of a bad jenkins job configuration on the previous Openshift Jenkins instance
  • I've added a flattening script to reduce the size of the MAGMA-MME image.

Test Plan

Already in production from my trusted-oai-ci-pipeline branch.

Additional Information

  • This change is backwards-breaking

@rdefosse rdefosse requested a review from a team as a code owner April 27, 2022 11:42
@rdefosse rdefosse requested a review from tmdzk April 27, 2022 11:42
@pull-request-size pull-request-size bot added the size/L Denotes a Pull Request that changes 100-499 lines. label Apr 27, 2022
@github-actions
Copy link
Contributor

Thanks for opening a PR! 💯

A couple initial guidelines

Howto

  • Reviews. The "Reviewers" listed for this PR are the Magma maintainers who will shepherd it.
  • Checks. All required CI checks must pass before merge.
  • Merge. Once approved and passing CI checks, use the ready2merge label to indicate the maintainers can merge your PR.

More info

Please take a moment to read through the Magma project's

If this is your first Magma PR, also consider reading

@github-actions github-actions bot added the component: ci All updates on CI (Jenkins/CircleCi/Github Action) label Apr 27, 2022
@rdefosse rdefosse force-pushed the oai-ci-apr-2022 branch 2 times, most recently from b32d530 to 0848132 Compare April 27, 2022 15:26
@nstng nstng self-requested a review April 27, 2022 15:28
Copy link
Contributor

@nstng nstng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rdefosse, some comments are only Nit, feel free to just resolve them if you do not agree.
In general this was a review by reading the code - as this change already runs on your Jenkins and you are satisfied with the results, I did not do additional experiments.
If you have something specific in mind that I can test, let me know.

ci-scripts/JenkinsFile-OAI-Container-GitHub Outdated Show resolved Hide resolved
ci-scripts/JenkinsFile-OAI-Container-GitHub Outdated Show resolved Hide resolved
ci-scripts/JenkinsFile-OAI-Container-GitHub Outdated Show resolved Hide resolved
ci-scripts/flatten_image.py Outdated Show resolved Hide resolved
ci-scripts/flatten_image.py Outdated Show resolved Hide resolved
ci-scripts/flatten_image.py Outdated Show resolved Hide resolved
ci-scripts/flatten_image.py Show resolved Hide resolved
ci-scripts/flatten_image.py Outdated Show resolved Hide resolved
ci-scripts/flatten_image.py Outdated Show resolved Hide resolved
ci-scripts/JenkinsFile-OAI-Container-GitHub Outdated Show resolved Hide resolved
Signed-off-by: Raphael Defosseux <raphael.defosseux@openairinterface.org>
Signed-off-by: Raphael Defosseux <raphael.defosseux@openairinterface.org>
Signed-off-by: Raphael Defosseux <raphael.defosseux@openairinterface.org>
…figured

Signed-off-by: Raphael Defosseux <raphael.defosseux@openairinterface.org>
Signed-off-by: Raphael Defosseux <raphael.defosseux@openairinterface.org>
Signed-off-by: Raphael Defosseux <raphael.defosseux@openairinterface.org>
Copy link
Contributor

@nstng nstng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@rdefosse rdefosse merged commit ca545de into magma:master Apr 28, 2022
@rdefosse rdefosse deleted the oai-ci-apr-2022 branch April 28, 2022 14:12
emakeev pushed a commit to emakeev/magma that referenced this pull request Aug 5, 2022
* fix(ci): handle the case when HTML file not present
* fix(ci): no more need for a git proxy in the Eurecom new infrastructure
* feat(ci): adding a flatten script to reduce the size of the target image
* fix(ci): no need to do the unshallow. Jenkins job is now properly configured
* fix(ci): fix typo
* fix(ci): doing the requested changes by code reviewer

Signed-off-by: Raphael Defosseux <raphael.defosseux@openairinterface.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: ci All updates on CI (Jenkins/CircleCi/Github Action) size/L Denotes a Pull Request that changes 100-499 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants