New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(ci): Latest fixes from Eurecom Infrastructure changes #12570
Conversation
Thanks for opening a PR! 💯
Howto
More infoPlease take a moment to read through the Magma project's
If this is your first Magma PR, also consider reading
|
b32d530
to
0848132
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@rdefosse, some comments are only Nit, feel free to just resolve them if you do not agree.
In general this was a review by reading the code - as this change already runs on your Jenkins and you are satisfied with the results, I did not do additional experiments.
If you have something specific in mind that I can test, let me know.
Signed-off-by: Raphael Defosseux <raphael.defosseux@openairinterface.org>
Signed-off-by: Raphael Defosseux <raphael.defosseux@openairinterface.org>
Signed-off-by: Raphael Defosseux <raphael.defosseux@openairinterface.org>
…figured Signed-off-by: Raphael Defosseux <raphael.defosseux@openairinterface.org>
Signed-off-by: Raphael Defosseux <raphael.defosseux@openairinterface.org>
Signed-off-by: Raphael Defosseux <raphael.defosseux@openairinterface.org>
0848132
to
02f1a64
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
* fix(ci): handle the case when HTML file not present * fix(ci): no more need for a git proxy in the Eurecom new infrastructure * feat(ci): adding a flatten script to reduce the size of the target image * fix(ci): no need to do the unshallow. Jenkins job is now properly configured * fix(ci): fix typo * fix(ci): doing the requested changes by code reviewer Signed-off-by: Raphael Defosseux <raphael.defosseux@openairinterface.org>
Summary
This month (
April 2022
), our hosting partner (Eurecom
) did a major network infrastructure upgrade. We had to modify a few things in the pipeline scripts:git fetch --unshallow
was made because of a bad jenkins job configuration on the previous Openshift Jenkins instanceTest Plan
Already in production from my
trusted-oai-ci-pipeline
branch.Additional Information