New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(ci): py linter only runs on added or modified files (not on deleted) #12584
Conversation
Thanks for opening a PR! 💯
Howto
More infoPlease take a moment to read through the Magma project's
If this is your first Magma PR, also consider reading
|
Oops! Looks like you failed the Howto
|
71a8bde
to
ebbe7fb
Compare
Signed-off-by: Nils Semmelrock <nils.semmelrock@tngtech.com>
ebbe7fb
to
5740c0d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice catch and thanks for the fix!
…ed) (magma#12584) Signed-off-by: Nils Semmelrock <nils.semmelrock@tngtech.com>
Summary
#12291 refactored the changed files mechanics to using
dorny/paths-filter
filesChanged
logic. The original--diff-filter=ACMRT
was not taken over correctly. This causespython-workflow.yml
to fail if a py file is deleted. See, e.g., https://github.com/magma/magma/runs/6195817220?check_suite_focus=true.Solution Here
Use
dorny/paths-filter
with additionadded|modified
filter.Test Plan
CI, see https://github.com/magma/magma/actions/runs/2238242192 for a run where a py file was deleted (dropped this test commit afterwards).
Additional Information