Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(nms): Remove legacy dashboard #12606

Merged
merged 1 commit into from May 9, 2022

Conversation

thmsschmitt
Copy link
Contributor

@thmsschmitt thmsschmitt commented Apr 29, 2022

Summary

The legacy UI that you get if you disable the V2 LTE Dashboard feature flag has be removed to reduce code complexity.
Screenshot 2022-04-29 at 16 47 55

The feature flag itself will be removed later together with the other unused flags.

Test Plan

Make sure that the UI looks as expected for LTE, FEG and FEG_LTE both with V2 LTE Dashboard enabled and disabled.

Use the linter to make sure the all imports can be resolved:

$ yarn eslint .
✖ 186 problems (0 errors, 186 warnings)

✨  Done in 19.35s.

@pull-request-size pull-request-size bot added the size/XXL Denotes a Pull Request that changes 1000+ lines. label Apr 29, 2022
@github-actions
Copy link
Contributor

Thanks for opening a PR! 💯

A couple initial guidelines

Howto

  • Reviews. The "Reviewers" listed for this PR are the Magma maintainers who will shepherd it.
  • Checks. All required CI checks must pass before merge.
  • Merge. Once approved and passing CI checks, use the ready2merge label to indicate the maintainers can merge your PR.

More info

Please take a moment to read through the Magma project's

If this is your first Magma PR, also consider reading

@github-actions github-actions bot added the component: nms NMS-related issue label Apr 29, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Apr 29, 2022

feg-workflow

    2 files  202 suites   38s ⏱️
371 tests 371 ✔️ 0 💤 0
385 runs  385 ✔️ 0 💤 0

Results for commit 410512d.

♻️ This comment has been updated with latest results.

@github-actions
Copy link
Contributor

github-actions bot commented Apr 29, 2022

nms-workflow

0 files  0 suites   0s ⏱️
0 tests 0 ✔️ 0 💤 0

Results for commit 410512d.

♻️ This comment has been updated with latest results.

@github-actions
Copy link
Contributor

github-actions bot commented Apr 29, 2022

cloud-workflow

    7 files  356 suites   2m 36s ⏱️
974 tests 974 ✔️ 0 💤 0

Results for commit 410512d.

♻️ This comment has been updated with latest results.

@github-actions
Copy link
Contributor

github-actions bot commented Apr 29, 2022

agw-workflow

     77 files     122 suites   7m 30s ⏱️
1 159 tests 1 150 ✔️ 9 💤 0
1 160 runs  1 151 ✔️ 9 💤 0

Results for commit 410512d.

♻️ This comment has been updated with latest results.

@thmsschmitt thmsschmitt force-pushed the remove-legacy-dashboard branch 6 times, most recently from d7c58e4 to c5a3748 Compare May 2, 2022 13:33
@thmsschmitt thmsschmitt marked this pull request as ready for review May 2, 2022 14:01
@thmsschmitt thmsschmitt requested review from a team and HannaFar May 2, 2022 14:01
@thmsschmitt thmsschmitt force-pushed the remove-legacy-dashboard branch 3 times, most recently from 13b64d8 to ba70c05 Compare May 4, 2022 06:28
Signed-off-by: Thomas Schmitt <thomas.schmitt@tngtech.com>
@thmsschmitt
Copy link
Contributor Author

@ShubhamTatvamasi @hcgatewood @arunuke would be good to get this reviewed, it is blocking a few things and the infra changes are really minimal.

@ShubhamTatvamasi
Copy link
Contributor

ShubhamTatvamasi commented May 9, 2022

Hi @thmsschmitt, we have to update helm chart versions for NMS and Orc8r both in this.

Copy link
Contributor

@ShubhamTatvamasi ShubhamTatvamasi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@thmsschmitt, there are other PRs also that will conflict with this PR if we update the helm version, so we will update it at the time of release.

@ShubhamTatvamasi ShubhamTatvamasi merged commit ab69e28 into magma:master May 9, 2022
emakeev pushed a commit to emakeev/magma that referenced this pull request Aug 5, 2022
Signed-off-by: Thomas Schmitt <thomas.schmitt@tngtech.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: nms NMS-related issue size/XXL Denotes a Pull Request that changes 1000+ lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants