New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(nms): Remove legacy dashboard #12606
refactor(nms): Remove legacy dashboard #12606
Conversation
Thanks for opening a PR! 💯
Howto
More infoPlease take a moment to read through the Magma project's
If this is your first Magma PR, also consider reading
|
d7c58e4
to
c5a3748
Compare
13b64d8
to
ba70c05
Compare
Signed-off-by: Thomas Schmitt <thomas.schmitt@tngtech.com>
ba70c05
to
410512d
Compare
@ShubhamTatvamasi @hcgatewood @arunuke would be good to get this reviewed, it is blocking a few things and the infra changes are really minimal. |
Hi @thmsschmitt, we have to update helm chart versions for NMS and Orc8r both in this. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@thmsschmitt, there are other PRs also that will conflict with this PR if we update the helm version, so we will update it at the time of release.
Signed-off-by: Thomas Schmitt <thomas.schmitt@tngtech.com>
Summary
The legacy UI that you get if you disable the
V2 LTE Dashboard
feature flag has be removed to reduce code complexity.The feature flag itself will be removed later together with the other unused flags.
Test Plan
Make sure that the UI looks as expected for LTE, FEG and FEG_LTE both with
V2 LTE Dashboard
enabled and disabled.Use the linter to make sure the all imports can be resolved: