Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: Fix s1ap federated integ test (missing build) #12609

Merged
merged 1 commit into from May 2, 2022
Merged

docs: Fix s1ap federated integ test (missing build) #12609

merged 1 commit into from May 2, 2022

Conversation

uri200
Copy link
Contributor

@uri200 uri200 commented Apr 29, 2022

Signed-off-by: Oriol Batalla obatalla@fb.com

Summary

Add a note to build the images the first time we run federated integ test

Test Plan

Additional Information

  • This change is backwards-breaking

@uri200 uri200 requested review from a team and Neudrino April 29, 2022 21:13
@pull-request-size pull-request-size bot added the size/XS Denotes a PR that changes 0-9 lines. label Apr 29, 2022
@github-actions
Copy link
Contributor

Thanks for opening a PR! 💯

A couple initial guidelines

Howto

  • Reviews. The "Reviewers" listed for this PR are the Magma maintainers who will shepherd it.
  • Checks. All required CI checks must pass before merge.
  • Merge. Once approved and passing CI checks, use the ready2merge label to indicate the maintainers can merge your PR.

More info

Please take a moment to read through the Magma project's

If this is your first Magma PR, also consider reading

@github-actions github-actions bot added the component: docs Documentation-related issue label Apr 29, 2022
@uri200 uri200 requested a review from themarwhal April 29, 2022 21:13
@uri200 uri200 enabled auto-merge (squash) April 29, 2022 21:14
@github-actions
Copy link
Contributor

github-actions bot commented Apr 29, 2022 •
edited

Oops! Looks like you failed the Semantic PR check.

Howto

♻️ Updated: ✅ The check is passing the Semantic PR after the last commit.

@uri200 uri200 force-pushed the s1ap_federated_integ_test_doc_fix_fab_command branch from 370ec1a to bc32aec Compare April 29, 2022 21:15
@uri200 uri200 changed the title [docs]: Fix s1ap federated integ test (missing build) (docs): Fix s1ap federated integ test (missing build) Apr 29, 2022
christinewang5
christinewang5 approved these changes Apr 29, 2022
View reviewed changes
Copy link
Contributor

@christinewang5 christinewang5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! thanks for fixing

docs/docusaurus/versioned_docs/version-1.7.0/feg/s1ap_federated_test.md
@@ -57,6 +57,10 @@ This script will

```bash
cd magma/lte/gatewat
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit typo here...

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will be fixed in #12610.

@Neudrino Neudrino mentioned this pull request May 2, 2022
Merged
Neudrino
Neudrino approved these changes May 2, 2022
View reviewed changes
docs/docusaurus/versioned_docs/version-1.7.0/feg/s1ap_federated_test.md
@@ -57,6 +57,10 @@ This script will

```bash
cd magma/lte/gatewat
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will be fixed in #12610.

@Neudrino Neudrino disabled auto-merge May 2, 2022 09:30
@Neudrino
Copy link
Contributor

Neudrino commented May 2, 2022 •
edited

Sematic PR needs to be fixed here, @uri200. E.g. docs: or the like.

@Neudrino Neudrino requested a review from voisey May 2, 2022 09:35
@uri200
docs: Fix s1ap federated integ test (missing build)
b9576b1 
Signed-off-by: Oriol Batalla <obatalla@fb.com>
@uri200 uri200 force-pushed the s1ap_federated_integ_test_doc_fix_fab_command branch from bc32aec to b9576b1 Compare May 2, 2022 18:18
@uri200 uri200 enabled auto-merge (squash) May 2, 2022 18:18
@uri200 uri200 changed the title (docs): Fix s1ap federated integ test (missing build) docs: Fix s1ap federated integ test (missing build) May 2, 2022
@uri200 uri200 merged commit 0113701 into magma:master May 2, 2022
emakeev pushed a commit to emakeev/magma that referenced this pull request Aug 5, 2022
@uri200 @emakeev
(docs): Fix s1ap federated integ test (missing build) (magma#12609)
43cd66d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Neudrino Neudrino Neudrino approved these changes

@christinewang5 christinewang5 christinewang5 approved these changes

@voisey voisey voisey approved these changes

@themarwhal themarwhal Awaiting requested review from themarwhal

Assignees
No one assigned
Labels
component: docs Documentation-related issue size/XS Denotes a PR that changes 0-9 lines.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@uri200 @Neudrino @christinewang5 @voisey