New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(nms): Remove fbc-js-core select component #12614
Merged
thmsschmitt
merged 1 commit into
magma:master
from
thmsschmitt:remove-fbc-js-core-select
May 10, 2022
Merged
refactor(nms): Remove fbc-js-core select component #12614
thmsschmitt
merged 1 commit into
magma:master
from
thmsschmitt:remove-fbc-js-core-select
May 10, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pull-request-size
bot
added
the
size/XXL
Denotes a Pull Request that changes 1000+ lines.
label
May 2, 2022
Thanks for opening a PR! 💯
Howto
More infoPlease take a moment to read through the Magma project's
If this is your first Magma PR, also consider reading
|
thmsschmitt
changed the title
refactor(nms): Remove fbc-js-core select
refactor(nms): Remove fbc-js-core Select component
May 2, 2022
thmsschmitt
force-pushed
the
remove-fbc-js-core-select
branch
from
May 3, 2022 10:03
99f4e20
to
a8ac9c2
Compare
thmsschmitt
changed the title
refactor(nms): Remove fbc-js-core Select component
refactor(nms): Remove fbc-js-core select component
May 3, 2022
thmsschmitt
force-pushed
the
remove-fbc-js-core-select
branch
from
May 3, 2022 14:03
a8ac9c2
to
a6dd8d4
Compare
Signed-off-by: Thomas Schmitt <thomas.schmitt@tngtech.com>
thmsschmitt
force-pushed
the
remove-fbc-js-core-select
branch
from
May 9, 2022 13:47
a6dd8d4
to
943547d
Compare
Neudrino
approved these changes
May 9, 2022
andreilee
approved these changes
May 10, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
stamped
emakeev
pushed a commit
to emakeev/magma
that referenced
this pull request
Aug 5, 2022
Signed-off-by: Thomas Schmitt <thomas.schmitt@tngtech.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
There was only one place left were the fbc-js-core
Select
component was used.It was next to a native Material-UI Select and looked out of place. The fbc-js-core
Select
component was replaced with the native Material-UI Select component and all related code has been deleted.Before
After
Test Plan
I made sure that creating users with the three different roles still works.
I also used the linter to check that no removed code was still in use.