Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(nms): Remove fbc-js-core select component #12614

Merged
merged 1 commit into from May 10, 2022

Conversation

thmsschmitt
Copy link
Contributor

@thmsschmitt thmsschmitt commented May 2, 2022

Summary

There was only one place left were the fbc-js-core Select component was used.
It was next to a native Material-UI Select and looked out of place. The fbc-js-core Select component was replaced with the native Material-UI Select component and all related code has been deleted.
Before
Screenshot 2022-05-02 at 15 01 22
After
Screenshot 2022-05-02 at 16 06 06

Test Plan

I made sure that creating users with the three different roles still works.

I also used the linter to check that no removed code was still in use.

$ yarn eslint .
...

✖ 186 problems (0 errors, 186 warnings)

✨  Done in 20.25s.

@pull-request-size pull-request-size bot added the size/XXL Denotes a Pull Request that changes 1000+ lines. label May 2, 2022
@github-actions
Copy link
Contributor

github-actions bot commented May 2, 2022

Thanks for opening a PR! 💯

A couple initial guidelines

Howto

  • Reviews. The "Reviewers" listed for this PR are the Magma maintainers who will shepherd it.
  • Checks. All required CI checks must pass before merge.
  • Merge. Once approved and passing CI checks, use the ready2merge label to indicate the maintainers can merge your PR.

More info

Please take a moment to read through the Magma project's

If this is your first Magma PR, also consider reading

@github-actions github-actions bot added the component: nms NMS-related issue label May 2, 2022
@thmsschmitt thmsschmitt changed the title refactor(nms): Remove fbc-js-core select refactor(nms): Remove fbc-js-core Select component May 2, 2022
@github-actions
Copy link
Contributor

github-actions bot commented May 2, 2022

feg-workflow

    2 files  202 suites   38s ⏱️
371 tests 371 ✔️ 0 💤 0
385 runs  385 ✔️ 0 💤 0

Results for commit a8ac9c2.

♻️ This comment has been updated with latest results.

@github-actions
Copy link
Contributor

github-actions bot commented May 2, 2022

nms-workflow

0 files  0 suites   0s ⏱️
0 tests 0 ✔️ 0 💤 0

Results for commit 943547d.

♻️ This comment has been updated with latest results.

@github-actions
Copy link
Contributor

github-actions bot commented May 2, 2022

cloud-workflow

    7 files  356 suites   2m 42s ⏱️
974 tests 974 ✔️ 0 💤 0

Results for commit a8ac9c2.

♻️ This comment has been updated with latest results.

@github-actions
Copy link
Contributor

github-actions bot commented May 2, 2022

agw-workflow

     77 files     122 suites   7m 23s ⏱️
1 158 tests 1 149 ✔️ 9 💤 0
1 159 runs  1 150 ✔️ 9 💤 0

Results for commit a8ac9c2.

♻️ This comment has been updated with latest results.

@thmsschmitt thmsschmitt changed the title refactor(nms): Remove fbc-js-core Select component refactor(nms): Remove fbc-js-core select component May 3, 2022
Signed-off-by: Thomas Schmitt <thomas.schmitt@tngtech.com>
@thmsschmitt thmsschmitt marked this pull request as ready for review May 9, 2022 14:05
@thmsschmitt thmsschmitt requested review from a team and HannaFar May 9, 2022 14:05
Copy link
Contributor

@andreilee andreilee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

stamped

@thmsschmitt thmsschmitt merged commit f58369a into magma:master May 10, 2022
emakeev pushed a commit to emakeev/magma that referenced this pull request Aug 5, 2022
Signed-off-by: Thomas Schmitt <thomas.schmitt@tngtech.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: nms NMS-related issue size/XXL Denotes a Pull Request that changes 1000+ lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants