refactor(nms): Inline fbc-js-core eslint config

[thmsschmitt]

Summary

We were still using the archived eslint-config-fbcnms package as base config for eslint.

The eslint-config-fbcnms has been inlined and some cleanup has been done:

• Overwritten rules have been merged
• eslint-config-prettier has been used to identify rules that conflict with prettier. As a result the comma-dangle rule and max-len rule were removed. The latter would still report warnings for comments that are ignored by prettier, but since they were only warnings they were also ignored by developers ;)
• The dependency to eslint-config-fbjs was removed because it all its rule were anyhow overwritten.

Test Plan

I made some changes that should break the linter to verify that they still do so.

[github-actions]

Thanks for opening a PR! 💯

A couple initial guidelines

• All commits must be signed off. This is enforced by DCO check.
• All PR titles must follow the semantic commits format. This is enforced by Semantic PR.

Howto

• Reviews. The "Reviewers" listed for this PR are the Magma maintainers who will shepherd it.
• Checks. All required CI checks must pass before merge.
• Merge. Once approved and passing CI checks, use the ready2merge label to indicate the maintainers can merge your PR.

More info

Please take a moment to read through the Magma project's

• Contributing Conventions for norms around contributed code

If this is your first Magma PR, also consider reading

• Developer Onboarding for onboarding as a new Magma developer
• Development Workflow for guidance on your first pull request
• CI Checks for points of contact for failing or flaky CI checks
• GitHub-to-Slack mappings for Magma maintainers for guidance on how to contact maintainers on Slack

[github-actions]

nms-workflow

0 files  0 suites   0s ⏱️
0 tests 0 ✔️ 0 💤 0 ❌

Results for commit 768e86b.

♻️ This comment has been updated with latest results.

[andreilee]

Looks clean!