Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(amf): Logging improvements at function level #12652

Merged
merged 5 commits into from Jun 2, 2022

Conversation

priya-wavelabs
Copy link
Contributor

@priya-wavelabs priya-wavelabs commented May 9, 2022

Summary

Modified the functions entry and exit points under OAI_LOG for tracing.

Test Plan

Verified with unit test.
Screenshot 2022-05-09 143338

Pcap:
image

Logs:
mme02.log

Additional Information

  • This change is backwards-breaking

@priya-wavelabs priya-wavelabs requested a review from a team May 9, 2022 08:59
@priya-wavelabs priya-wavelabs self-assigned this May 9, 2022
@pull-request-size pull-request-size bot added the size/XL Denotes a Pull Request that changes 500-999 lines. label May 9, 2022
@github-actions
Copy link
Contributor

github-actions bot commented May 9, 2022

Thanks for opening a PR! 💯

A couple initial guidelines

Howto

  • Reviews. The "Reviewers" listed for this PR are the Magma maintainers who will shepherd it.
  • Checks. All required CI checks must pass before merge.
  • Merge. Once approved and passing CI checks, use the ready2merge label to indicate the maintainers can merge your PR.

More info

Please take a moment to read through the Magma project's

If this is your first Magma PR, also consider reading

@github-actions github-actions bot added the component: agw Access gateway-related issue label May 9, 2022
@github-actions
Copy link
Contributor

github-actions bot commented May 9, 2022

feg-workflow

    2 files  202 suites   37s ⏱️
371 tests 371 ✔️ 0 💤 0
385 runs  385 ✔️ 0 💤 0

Results for commit c0a30d6.

♻️ This comment has been updated with latest results.

@priya-wavelabs priya-wavelabs linked an issue May 9, 2022 that may be closed by this pull request
@github-actions
Copy link
Contributor

github-actions bot commented May 9, 2022

agw-workflow

     77 files     122 suites   6m 23s ⏱️
1 151 tests 1 147 ✔️ 4 💤 0
1 152 runs  1 148 ✔️ 4 💤 0

Results for commit c0a30d6.

♻️ This comment has been updated with latest results.

Copy link
Contributor

@ganeshg87 ganeshg87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@github-actions
Copy link
Contributor

github-actions bot commented May 24, 2022

dp-workflow

  2 files    2 suites   3m 36s ⏱️
15 tests 15 ✔️ 0 💤 0

Results for commit c0a30d6.

♻️ This comment has been updated with latest results.

Copy link
Contributor

@rsarwad rsarwad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Signed-off-by: priya-wavelabs <priya.agrawal@wavelabs.ai>
Signed-off-by: priya-wavelabs <priya.agrawal@wavelabs.ai>
Signed-off-by: priya-wavelabs <priya.agrawal@wavelabs.ai>
Signed-off-by: priya-wavelabs <priya.agrawal@wavelabs.ai>
Signed-off-by: priya-wavelabs <priya.agrawal@wavelabs.ai>
@panyogesh
Copy link
Contributor

LGTM

@panyogesh panyogesh merged commit ccccfda into magma:master Jun 2, 2022
emakeev pushed a commit to emakeev/magma that referenced this pull request Aug 5, 2022
* feat(amf): Logging improvements at function level

Signed-off-by: priya-wavelabs <priya.agrawal@wavelabs.ai>

* Addressed review comments (R1)

Signed-off-by: priya-wavelabs <priya.agrawal@wavelabs.ai>

* Addressed review comments (R2)

Signed-off-by: priya-wavelabs <priya.agrawal@wavelabs.ai>

* Addressed review comments (R3)

Signed-off-by: priya-wavelabs <priya.agrawal@wavelabs.ai>

* Addressed review comments (R4)

Signed-off-by: priya-wavelabs <priya.agrawal@wavelabs.ai>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: agw Access gateway-related issue priority: low Low priority bug product: 5g sa size/XL Denotes a Pull Request that changes 500-999 lines. type: bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[NGAP][AMF]: To support profiling the major functions
4 participants