New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(amf): Logging improvements at function level #12652
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pull-request-size
bot
added
the
size/XL
Denotes a Pull Request that changes 500-999 lines.
label
May 9, 2022
Thanks for opening a PR! 💯
Howto
More infoPlease take a moment to read through the Magma project's
If this is your first Magma PR, also consider reading
|
1 task
rsarwad
reviewed
May 9, 2022
rsarwad
reviewed
May 9, 2022
priya-wavelabs
force-pushed
the
ngap_amf_12277
branch
from
May 11, 2022 08:21
1b72c8b
to
7501174
Compare
panyogesh
added
product: 5g sa
priority: low
Low priority bug
type: bug
Something isn't working
labels
May 19, 2022
ganeshg87
approved these changes
May 20, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
priya-wavelabs
force-pushed
the
ngap_amf_12277
branch
from
May 24, 2022 06:19
7501174
to
e7b85d7
Compare
rsarwad
reviewed
Jun 2, 2022
priya-wavelabs
force-pushed
the
ngap_amf_12277
branch
from
June 2, 2022 10:08
e7b85d7
to
d512c0a
Compare
rsarwad
approved these changes
Jun 2, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Signed-off-by: priya-wavelabs <priya.agrawal@wavelabs.ai>
Signed-off-by: priya-wavelabs <priya.agrawal@wavelabs.ai>
Signed-off-by: priya-wavelabs <priya.agrawal@wavelabs.ai>
Signed-off-by: priya-wavelabs <priya.agrawal@wavelabs.ai>
Signed-off-by: priya-wavelabs <priya.agrawal@wavelabs.ai>
priya-wavelabs
force-pushed
the
ngap_amf_12277
branch
from
June 2, 2022 13:40
d512c0a
to
c0a30d6
Compare
LGTM |
emakeev
pushed a commit
to emakeev/magma
that referenced
this pull request
Aug 5, 2022
* feat(amf): Logging improvements at function level Signed-off-by: priya-wavelabs <priya.agrawal@wavelabs.ai> * Addressed review comments (R1) Signed-off-by: priya-wavelabs <priya.agrawal@wavelabs.ai> * Addressed review comments (R2) Signed-off-by: priya-wavelabs <priya.agrawal@wavelabs.ai> * Addressed review comments (R3) Signed-off-by: priya-wavelabs <priya.agrawal@wavelabs.ai> * Addressed review comments (R4) Signed-off-by: priya-wavelabs <priya.agrawal@wavelabs.ai>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
component: agw
Access gateway-related issue
priority: low
Low priority bug
product: 5g sa
size/XL
Denotes a Pull Request that changes 500-999 lines.
type: bug
Something isn't working
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Modified the functions entry and exit points under OAI_LOG for tracing.
Test Plan
Verified with unit test.
Pcap:
Logs:
mme02.log
Additional Information