chore(health): Bazelify health service #12654
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pull-request-size
bot
added
the
size/L
|
Thanks for opening a PR! 💯
Howto
More infoPlease take a moment to read through the Magma project's
If this is your first Magma PR, also consider reading
|
sebathomas
approved these changes
May 10, 2022
vktng
force-pushed
the
bazelify_health_service
branch
from
2250587
to
9f9503c
Compare
Signed-off-by: Krisztián Varga <krisztian.varga@tngtech.com>
Signed-off-by: Krisztián Varga <krisztian.varga@tngtech.com>
Signed-off-by: Krisztián Varga <krisztian.varga@tngtech.com>
vktng
force-pushed
the
bazelify_health_service
branch
from
9f9503c
to
76e983d
Compare
LKreutzer
approved these changes
May 10, 2022
sebathomas
approved these changes
May 10, 2022
nstng
approved these changes
May 10, 2022
emakeev
pushed a commit
to emakeev/magma
that referenced
this pull request
Aug 5, 2022
* test(health): Add a unit test for the health service Signed-off-by: Krisztián Varga <krisztian.varga@tngtech.com> * chore(health): Bazelify health service Signed-off-by: Krisztián Varga <krisztian.varga@tngtech.com> * chore(health): Bazelify health service tests Signed-off-by: Krisztián Varga <krisztian.varga@tngtech.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds a new unit test for the health service, and bazelifies both the service and the new test.
Test Plan
Execute the service with Bazel on Devcontainer, Bazel-base and the VM:
bazel run lte/gateway/python/magma/health:healthTest the service with Bazel on Devcontainer, Bazel-base and the VM:
bazel test lte/gateway/python/magma/health/tests/...Additional Information