Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(nms): Move babel-register out of fbc_js_core #12662

Merged

Conversation

thmsschmitt
Copy link
Contributor

Summary

This part of a bigger refactoring where everything in fbc_js_core will be merged into the same directory structure as the rest of the application.

Test Plan

I rebuild the docker container and made sure that the application still runs. I also executed the e2e test locally.

@pull-request-size pull-request-size bot added the size/M Denotes a PR that changes 30-99 lines. label May 10, 2022
@github-actions
Copy link
Contributor

Thanks for opening a PR! 💯

A couple initial guidelines

Howto

  • Reviews. The "Reviewers" listed for this PR are the Magma maintainers who will shepherd it.
  • Checks. All required CI checks must pass before merge.
  • Merge. Once approved and passing CI checks, use the ready2merge label to indicate the maintainers can merge your PR.

More info

Please take a moment to read through the Magma project's

If this is your first Magma PR, also consider reading

@github-actions github-actions bot added the component: nms NMS-related issue label May 10, 2022
@github-actions
Copy link
Contributor

github-actions bot commented May 10, 2022

nms-workflow

0 files  0 suites   0s ⏱️
0 tests 0 ✔️ 0 💤 0

Results for commit 197b842.

♻️ This comment has been updated with latest results.

@thmsschmitt thmsschmitt marked this pull request as ready for review May 10, 2022 08:44
@thmsschmitt thmsschmitt requested review from a team and andreilee May 10, 2022 08:44
Signed-off-by: Thomas Schmitt <thomas.schmitt@tngtech.com>
@thmsschmitt thmsschmitt force-pushed the integrate-fbc-js-core-babel-register branch from d192b95 to 197b842 Compare May 10, 2022 12:21
@thmsschmitt thmsschmitt merged commit e0f97b7 into magma:master May 12, 2022
emakeev pushed a commit to emakeev/magma that referenced this pull request Aug 5, 2022
Signed-off-by: Thomas Schmitt <thomas.schmitt@tngtech.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: nms NMS-related issue size/M Denotes a PR that changes 30-99 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants