Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Add size attribute to all bazel test targets #12686

Merged
merged 1 commit into from May 12, 2022

Conversation

LKreutzer
Copy link
Contributor

Signed-off-by: Lars Kreutzer lars.kreutzer@tngtech.com

Summary

  • Add "size" attribute to every bazel test target.
  • This sets the correct timeouts for all unit tests - see bazel docs.
  • If a test took >~10s I used the "medium" label in order to avoid a one minute timeout on slow machines.

Test Plan

  • Check that all tests have the attribute:
bazel query 'attr(size, small , tests(//...))' > tests-with-size.txt && \
bazel query 'attr(size, medium , tests(//...))' >> tests-with-size.txt && \ 
bazel query 'attr(size, large , tests(//...))' >> tests-with-size.txt && \
bazel query 'kind(".*_test", attr("name",".*","//..."))' > anytest.txt && \ 
diff tests-with-size.txt anytest.txt
  • Run all unit tests bazel test //...
  • CI

Additional Information

  • This change is backwards-breaking

Signed-off-by: Lars Kreutzer <lars.kreutzer@tngtech.com>
@LKreutzer LKreutzer added the bazel changes for the Bazelification effort label May 11, 2022
@LKreutzer LKreutzer self-assigned this May 11, 2022
@LKreutzer LKreutzer requested review from a team and nstng May 11, 2022 07:53
@pull-request-size pull-request-size bot added the size/M Denotes a PR that changes 30-99 lines. label May 11, 2022
@github-actions
Copy link
Contributor

Thanks for opening a PR! 💯

A couple initial guidelines

Howto

  • Reviews. The "Reviewers" listed for this PR are the Magma maintainers who will shepherd it.
  • Checks. All required CI checks must pass before merge.
  • Merge. Once approved and passing CI checks, use the ready2merge label to indicate the maintainers can merge your PR.

More info

Please take a moment to read through the Magma project's

If this is your first Magma PR, also consider reading

@github-actions github-actions bot added the component: agw Access gateway-related issue label May 11, 2022
@github-actions
Copy link
Contributor

feg-workflow

    2 files  202 suites   38s ⏱️
371 tests 371 ✔️ 0 💤 0
385 runs  385 ✔️ 0 💤 0

Results for commit ccedf40.

@github-actions
Copy link
Contributor

agw-workflow

     77 files     122 suites   6m 40s ⏱️
1 159 tests 1 150 ✔️ 9 💤 0
1 160 runs  1 151 ✔️ 9 💤 0

Results for commit ccedf40.

Copy link
Contributor

@nstng nstng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thank you for the detailed review queries

@nstng nstng merged commit ee31f99 into magma:master May 12, 2022
emakeev pushed a commit to emakeev/magma that referenced this pull request Aug 5, 2022
Signed-off-by: Lars Kreutzer <lars.kreutzer@tngtech.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bazel changes for the Bazelification effort component: agw Access gateway-related issue size/M Denotes a PR that changes 30-99 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants