Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(sessiond): GRPC printing #12709

Merged
merged 2 commits into from May 31, 2022
Merged

Conversation

vikramgreddy
Copy link
Contributor

Signed-off-by: Vikram G vikram.gurrappagaru@radisys.com

Summary

PrintGrpcMessage to DirectorydClient.cpp on request

Test Plan

make integ_test
make test session_manager

Additional Information

Signed-off-by: Vikram G <vikram.gurrappagaru@radisys.com>
@vikramgreddy vikramgreddy requested review from a team and prabinakpattnaik May 13, 2022 03:51
@pull-request-size pull-request-size bot added the size/XS Denotes a PR that changes 0-9 lines. label May 13, 2022
@github-actions
Copy link
Contributor

Thanks for opening a PR! 💯

A couple initial guidelines

Howto

  • Reviews. The "Reviewers" listed for this PR are the Magma maintainers who will shepherd it.
  • Checks. All required CI checks must pass before merge.
  • Merge. Once approved and passing CI checks, use the ready2merge label to indicate the maintainers can merge your PR.

More info

Please take a moment to read through the Magma project's

If this is your first Magma PR, also consider reading

@github-actions github-actions bot added the component: agw Access gateway-related issue label May 13, 2022
@github-actions
Copy link
Contributor

github-actions bot commented May 13, 2022

feg-workflow

    2 files  202 suites   37s ⏱️
371 tests 371 ✔️ 0 💤 0
385 runs  385 ✔️ 0 💤 0

Results for commit 6f04a68.

♻️ This comment has been updated with latest results.

Copy link
Contributor

@uri200 uri200 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @vikramgreddy.

This will print the request. We will also need to print the response.
Unfortunately the way CPP manages grpc message does not allow us to use the same strategy here, so using your IDE, please search all the instances where those functions are called and print the response. For example here
http://github.com/magma/magma/blob/master/lte/gateway/c/session_manager/SessionProxyResponderHandler.cpp#L78-L78

@uri200
Copy link
Contributor

uri200 commented May 13, 2022

Also you can try to see the logs running S1AP test and enable grpc printing on sessiond.yml. To do that you could go your vagrant vm and change print_grpc_payload: True at /etc/magma/sessiond.yml. Then from your host (not vagrant) you can run

cd magma/lte/gateway
 fab integ_test:provision_vm=False,rerun_fails=0,no_build=True,skip_unit_tests=True

To run the test.

From your Vagrant VM you will be able to see sessiond logs using

sudo journalctl -fu magma@sessiond

In case you need it, you can add some extra prints to the function and rebuild sessiond to see if they print the message.

Note that using s1ap tester will be very useful on the future to test out stuff that can't be tested with unit test

@github-actions
Copy link
Contributor

github-actions bot commented May 13, 2022

agw-workflow

     77 files     122 suites   6m 42s ⏱️
1 157 tests 1 153 ✔️ 4 💤 0
1 158 runs  1 154 ✔️ 4 💤 0

Results for commit 6f04a68.

♻️ This comment has been updated with latest results.

Signed-off-by: Vikram G <vikram.gurrappagaru@radisys.com>
@ssanadhya ssanadhya merged commit 67d4f28 into magma:master May 31, 2022
emakeev pushed a commit to emakeev/magma that referenced this pull request Aug 5, 2022
* chore(sessiond): GRPC printing
Signed-off-by: Vikram G <vikram.gurrappagaru@radisys.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: agw Access gateway-related issue size/XS Denotes a PR that changes 0-9 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants