feat(ci): add eslint to reviewdog #12713
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for opening a PR! 💯
Howto
More infoPlease take a moment to read through the Magma project's
If this is your first Magma PR, also consider reading
|
github-actions
bot
added
component: ci
pull-request-size
bot
added
size/M
Neudrino
force-pushed
the
ci/reviewdog-for-eslint
branch
from
df8de2a
to
1cb99c0
Compare
Neudrino
force-pushed
the
ci/reviewdog-for-eslint
branch
from
f055998
to
bbe1798
Compare
Neudrino
force-pushed
the
ci/reviewdog-for-eslint
branch
from
bbe1798
to
d2056c1
Compare
Signed-off-by: Fritz Lehnert <13189449+Neudrino@users.noreply.github.com>
Signed-off-by: Fritz Lehnert <13189449+Neudrino@users.noreply.github.com>
Neudrino
force-pushed
the
ci/reviewdog-for-eslint
branch
from
d2056c1
to
3e864ca
Compare
thmsschmitt
reviewed
May 13, 2022
| @@ -117,7 +117,7 @@ | |||
| "prettier": "^2.0.5", | |||
| "puppeteer": "5.5.0", | |||
| "react-hot-loader": "^4.8.0", | |||
| "react-test-renderer": "^17.0.2", | |||
| "react-test-renderer": "^16.9.0", | |||
There was a problem hiding this comment.
Makes sense, we should use a test renderer that fits to our react version.
| @@ -113,6 +116,26 @@ jobs: | |||
| # Ignore DL3005-"Do not use apt-get upgrade or dist-upgrade" | |||
| hadolint_ignore: DL3005 | |||
|
|
|||
| eslint: | |||
There was a problem hiding this comment.
Does that mean we are now running eslint twice once as part of the nms workflow and ones in the reviewdog workflow?
There was a problem hiding this comment.
That is correct. However, I do not see an issue with that, as it will be run in parallel and thus not prolong the CI execution.
I would see this as first step in part of a larger consolidation of the CI, in this part of linters and formatters.
Anyhow, for now, it brings the advantage that people opening a PR see in the PR conversation, what issues the Linter shows, instead of only having those hidden in the run logs of the action.
jheidbrink
approved these changes
May 24, 2022
thmsschmitt
approved these changes
Jun 23, 2022
emakeev
pushed a commit
to emakeev/magma
that referenced
this pull request
Aug 5, 2022
* feat(ci): add eslint to reviewdog Signed-off-by: Fritz Lehnert <13189449+Neudrino@users.noreply.github.com> * feat(ci): pin react-test-renderer version Signed-off-by: Fritz Lehnert <13189449+Neudrino@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
eslintis used in the JavaScript universe and specifically for the NMS frontend in magma.This integrates the linter with reviewdog for a visual feedback in Github.
The change to the yarn package install is necessary, because otherwise the npm install step fails in CI.
yarn.lockautomatically updated by runningyarn.Test Plan