Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(nms): allow todate in the copyright #12714

Merged
merged 1 commit into from May 13, 2022

Conversation

Neudrino
Copy link
Contributor

Summary

Allows to take some other year than just 2020 in the copyright notice for NMS.

Test Plan

  • yarn run eslint . --quiet with a 2022 in one header file

Signed-off-by: Fritz Lehnert <13189449+Neudrino@users.noreply.github.com>
@pull-request-size pull-request-size bot added the size/XS Denotes a PR that changes 0-9 lines. label May 13, 2022
@github-actions
Copy link
Contributor

Thanks for opening a PR! 💯

A couple initial guidelines

Howto

  • Reviews. The "Reviewers" listed for this PR are the Magma maintainers who will shepherd it.
  • Checks. All required CI checks must pass before merge.
  • Merge. Once approved and passing CI checks, use the ready2merge label to indicate the maintainers can merge your PR.

More info

Please take a moment to read through the Magma project's

If this is your first Magma PR, also consider reading

@Neudrino Neudrino requested a review from thmsschmitt May 13, 2022 12:01
@github-actions github-actions bot added the component: nms NMS-related issue label May 13, 2022
@Neudrino Neudrino marked this pull request as ready for review May 13, 2022 12:01
@Neudrino Neudrino requested a review from a team May 13, 2022 12:01
@Neudrino Neudrino enabled auto-merge (squash) May 13, 2022 12:02
Copy link
Contributor

@sebathomas sebathomas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing, this check was annoying!

@github-actions
Copy link
Contributor

nms-workflow

0 files  0 suites   0s ⏱️
0 tests 0 ✔️ 0 💤 0

Results for commit 4ee747d.

@Neudrino Neudrino merged commit f2c486d into magma:master May 13, 2022
@Neudrino Neudrino deleted the nms/fix-header-linting-issue branch May 13, 2022 13:02
emakeev pushed a commit to emakeev/magma that referenced this pull request Aug 5, 2022
Signed-off-by: Fritz Lehnert <13189449+Neudrino@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: nms NMS-related issue size/XS Denotes a PR that changes 0-9 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants