refactor(orc8r): replace deprecated errors module #12724
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pull-request-size
bot
added
the
size/XL
|
Thanks for opening a PR! 💯
Howto
More infoPlease take a moment to read through the Magma project's
If this is your first Magma PR, also consider reading
|
pull-request-size
bot
added
size/XXL
6 tasks
wolfseb
force-pushed
the
errors_to_stdlib_errors_orc8r
branch
from
fac2483
to
b374fbe
Compare
wolfseb
force-pushed
the
errors_to_stdlib_errors_orc8r
branch
from
b374fbe
to
9c4f6d7
Compare
wolfseb
force-pushed
the
errors_to_stdlib_errors_orc8r
branch
5 times, most recently
from
3364a91
to
ca1c648
Compare
wolfseb
force-pushed
the
errors_to_stdlib_errors_orc8r
branch
3 times, most recently
from
2c040ba
to
eebff2b
Compare
1 task
alexzurbonsen
approved these changes
May 18, 2022
| @@ -15,9 +15,9 @@ package southbound | |||
|
|
|||
| import ( | |||
| "context" | |||
| "errors" | |||
There was a problem hiding this comment.
The cases in which std lib "errors" is imported without obvious use in the diff, are due to replacing errors.New from pkg/errors by errors.New from std lib, I assume?
There was a problem hiding this comment.
Yes, exactly. In the same file you should find a removal of github.com/pkg/errors
maxhbr
reviewed
May 23, 2022
| @@ -27,7 +28,7 @@ func MarshalConfigs(configs map[string]proto.Message) (ConfigsByKey, error) { | |||
| for k, v := range configs { | |||
| anyVal, err := ptypes.MarshalAny(v) | |||
| if err != nil { | |||
| return nil, errors.WithStack(err) | |||
There was a problem hiding this comment.
We have no replacement for errors.WithStack?
There was a problem hiding this comment.
No, you still get the file name and line but no call stack.
wolfseb
force-pushed
the
errors_to_stdlib_errors_orc8r
branch
from
eebff2b
to
deafe42
Compare
Replace functions from the github.com/pgk/errors package with `fmt.Errorf` in /magma/orc8r. Created in pairing with Moritz Huebner. Signed-off-by: Sebastian Wolf <sebastian.wolf@tngtech.com>
Replace functions from the github.com/pgk/errors package with `fmt.Errorf` in /magma/lte. Created in pairing with Moritz Huebner. Signed-off-by: Sebastian Wolf <sebastian.wolf@tngtech.com>
wolfseb
force-pushed
the
errors_to_stdlib_errors_orc8r
branch
from
deafe42
to
2e759c2
Compare
wolfseb
added
the
ready2merge
mpfirrmann
pushed a commit
to mpfirrmann/magma
that referenced
this pull request
May 31, 2022
* refactor(orc8r): replace deprecated errors module Replace functions from the github.com/pgk/errors package with `fmt.Errorf` in /magma/orc8r. Created in pairing with Moritz Huebner. Signed-off-by: Sebastian Wolf <sebastian.wolf@tngtech.com> * refactor(orc8r): replace deprecated errors module Replace functions from the github.com/pgk/errors package with `fmt.Errorf` in /magma/lte. Created in pairing with Moritz Huebner. Signed-off-by: Sebastian Wolf <sebastian.wolf@tngtech.com>
emakeev
pushed a commit
to emakeev/magma
that referenced
this pull request
Aug 5, 2022
* refactor(orc8r): replace deprecated errors module Replace functions from the github.com/pgk/errors package with `fmt.Errorf` in /magma/orc8r. Created in pairing with Moritz Huebner. Signed-off-by: Sebastian Wolf <sebastian.wolf@tngtech.com> * refactor(orc8r): replace deprecated errors module Replace functions from the github.com/pgk/errors package with `fmt.Errorf` in /magma/lte. Created in pairing with Moritz Huebner. Signed-off-by: Sebastian Wolf <sebastian.wolf@tngtech.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace functions from the github.com/pgk/errors package with
fmt.Errorf. Created in pairing with Moritz Huebner.Signed-off-by: Sebastian Wolf sebastian.wolf@tngtech.com
Summary
This PR implements the proposed solutions of ticket #12632 for the orc8r module.
A few instances of broken rollback error handling next to the changes
in this PR are also fixed.
Test Plan
Perform Unit tests
Additional Information
Worked in pairing with @MoritzThomasHuebner