Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(amf): Registration reject handling for mismatching plmn #12733

Merged
merged 1 commit into from Jun 9, 2022
Merged

fix(amf): Registration reject handling for mismatching plmn #12733

merged 1 commit into from Jun 9, 2022

Conversation

Sathyaj27
Copy link
Contributor

Signed-off-by: Sathyaj27 sathya.jayadev@wavelabs.ai

Fixing #12536
Issue:
There was no mcc mnc validation at registration request.
Added the validation check

Test Plan

  • Added UT. UT is passing
  • Tested on spirent setup. Attached pcap :

reject

Additional Information

  • This change is not backwards-breaking

@pull-request-size pull-request-size bot added the size/M Denotes a PR that changes 30-99 lines. label May 16, 2022
@github-actions
Copy link
Contributor

Thanks for opening a PR! 💯

A couple initial guidelines

Howto

  • Reviews. The "Reviewers" listed for this PR are the Magma maintainers who will shepherd it.
  • Checks. All required CI checks must pass before merge.
  • Merge. Once approved and passing CI checks, use the ready2merge label to indicate the maintainers can merge your PR.

More info

Please take a moment to read through the Magma project's

If this is your first Magma PR, also consider reading

@github-actions github-actions bot added the component: agw Access gateway-related issue label May 16, 2022
@Sathyaj27 Sathyaj27 added priority: high High Priority Bug product: 5g sa component: agw Access gateway-related issue and removed component: agw Access gateway-related issue labels May 16, 2022
@github-actions
Copy link
Contributor

github-actions bot commented May 16, 2022 •
edited

feg-workflow

    2 files  202 suites   37s ⏱️
371 tests 371 ✔️ 0 💤 0 ❌
385 runs  385 ✔️ 0 💤 0 ❌

Results for commit 478dfa7.

♻️ This comment has been updated with latest results.

@moinuddin1980 moinuddin1980 changed the title fix(amf): Registration reject handling for mimatching plmn fix(amf): Registration reject handling for mismatching plmn May 16, 2022
@github-actions
Copy link
Contributor

github-actions bot commented May 16, 2022 •
edited

agw-workflow

     77 files     122 suites   6m 12s ⏱️
1 152 tests 1 148 ✔️ 4 💤 0 ❌
1 153 runs  1 149 ✔️ 4 💤 0 ❌

Results for commit 478dfa7.

♻️ This comment has been updated with latest results.

@github-actions
Copy link
Contributor

github-actions bot commented May 19, 2022 •
edited

dp-workflow

18 tests   18 ✔️  4m 24s ⏱️
  2 suites    0 💤
  2 files      0 ❌

Results for commit 478dfa7.

♻️ This comment has been updated with latest results.

@Sathyaj27 Sathyaj27 marked this pull request as ready for review May 19, 2022 10:46
@Sathyaj27 Sathyaj27 requested review from a team and Kaleem-Wavelabs May 19, 2022 10:46
@netlify
Copy link

netlify bot commented May 20, 2022

👷 Deploy request for competent-euler-513227 pending review.

Visit the deploys page to approve it

Name Link
🔨 Latest commit f171bf7

ganeshg87
ganeshg87 approved these changes May 25, 2022
View reviewed changes
Copy link
Contributor

@ganeshg87 ganeshg87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Sathyaj27 Sathyaj27 force-pushed the rejectissue branch 4 times, most recently from 136c117 to 327a647 Compare June 1, 2022 03:27
@Sathyaj27
fix(amf): Registration reject handling for mismatching plmn
478dfa7 
Signed-off-by: Sathyaj27 <sathya.jayadev@wavelabs.ai>
pruthvihebbani
pruthvihebbani approved these changes Jun 9, 2022
View reviewed changes
Copy link
Contributor

@pruthvihebbani pruthvihebbani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@panyogesh panyogesh merged commit 513e900 into magma:master Jun 9, 2022
@Sathyaj27 Sathyaj27 deleted the rejectissue branch June 16, 2022 03:29
@panyogesh panyogesh mentioned this pull request Jul 14, 2022
Closed
emakeev pushed a commit to emakeev/magma that referenced this pull request Aug 5, 2022
@Sathyaj27 @emakeev
fix(amf): Registration reject handling for mismatching plmn (magma#12733
0a2cfe8 
)

Signed-off-by: Sathyaj27 <sathya.jayadev@wavelabs.ai>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions github-actions[bot] github-actions left review comments

@pruthvihebbani pruthvihebbani pruthvihebbani approved these changes

@ganeshg87 ganeshg87 ganeshg87 approved these changes

@Kaleem-Wavelabs Kaleem-Wavelabs Awaiting requested review from Kaleem-Wavelabs

Assignees
No one assigned
Labels
component: agw Access gateway-related issue priority: high High Priority Bug product: 5g sa size/M Denotes a PR that changes 30-99 lines.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@Sathyaj27 @pruthvihebbani @ganeshg87 @panyogesh