Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(orc8r): Move cloud/go/obsidian to cloud/go/services #12742

Merged
merged 1 commit into from Jun 27, 2022
Merged

refactor(orc8r): Move cloud/go/obsidian to cloud/go/services #12742

merged 1 commit into from Jun 27, 2022

Conversation

MoritzThomasHuebner
Copy link
Contributor

@MoritzThomasHuebner MoritzThomasHuebner commented May 17, 2022 •
edited

Summary

Obsidian should live among the other services in orc8r/cloud/go/services.

For this PR I have

  • Moved the package
  • Changed paths across magma to reflect the move
  • Ran go clean_gen to properly recreate the obsidian/swagger/protos/swagger.pb.go file
  • There is an update required for the CODEOWNERS file for which I will create a separate PR.
  • CodeQL tests are highlighting a known logging vulnerability. This issue existed prior to this PR and there is no consensus yet on how too solve this. See 11738.

Edit:
I rebased this onto #12725, and it should thus be merged after that PR. The diff currently also shows changes from #12725 until it is merged.

Test Plan

Run unit tests

Additional Information

  • This change is backwards-breaking

@pull-request-size pull-request-size bot added the size/L Denotes a Pull Request that changes 100-499 lines. label May 17, 2022
@github-actions
Copy link
Contributor

Thanks for opening a PR! 💯

A couple initial guidelines

Howto

  • Reviews. The "Reviewers" listed for this PR are the Magma maintainers who will shepherd it.
  • Checks. All required CI checks must pass before merge.
  • Merge. Once approved and passing CI checks, use the ready2merge label to indicate the maintainers can merge your PR.

More info

Please take a moment to read through the Magma project's

If this is your first Magma PR, also consider reading

@github-actions github-actions bot added component: ci All updates on CI (Jenkins/CircleCi/Github Action) component: cwf component: feg FEG-gateway related issues component: orc8r Orchestrator-related issue labels May 17, 2022
@github-actions
Copy link
Contributor

github-actions bot commented May 17, 2022 •
edited

feg-workflow

    2 files  203 suites   40s ⏱️
374 tests 374 ✔️ 0 💤 0 ❌
388 runs  388 ✔️ 0 💤 0 ❌

Results for commit 4851518.

♻️ This comment has been updated with latest results.

@github-actions
Copy link
Contributor

github-actions bot commented May 17, 2022 •
edited

cloud-workflow

988 tests   988 ✔️  2m 11s ⏱️
355 suites      0 💤
    7 files        0 ❌

Results for commit 4851518.

♻️ This comment has been updated with latest results.

@github-actions
Copy link
Contributor

github-actions bot commented May 17, 2022 •
edited

dp-workflow

18 tests   18 ✔️  4m 23s ⏱️
  2 suites    0 💤
  2 files      0 ❌

Results for commit 4851518.

♻️ This comment has been updated with latest results.

@MoritzThomasHuebner MoritzThomasHuebner force-pushed the Move_orc8r/cloud/go/obsidian_under_orc8r/cloud/go/services branch from 5878db6 to a96e213 Compare May 17, 2022 07:42
@github-actions
Copy link
Contributor

github-actions bot commented May 17, 2022 •
edited

agw-workflow

    2 files      2 suites   3m 30s ⏱️
579 tests 575 ✔️ 4 💤 0 ❌
580 runs  576 ✔️ 4 💤 0 ❌

Results for commit 4851518.

♻️ This comment has been updated with latest results.

@MoritzThomasHuebner MoritzThomasHuebner force-pushed the Move_orc8r/cloud/go/obsidian_under_orc8r/cloud/go/services branch 2 times, most recently from 3d23bf5 to b9e1dfe Compare May 18, 2022 07:59
@MoritzThomasHuebner MoritzThomasHuebner marked this pull request as ready for review May 18, 2022 08:42
@MoritzThomasHuebner MoritzThomasHuebner requested review from a team May 18, 2022 08:42
@MoritzThomasHuebner MoritzThomasHuebner requested a review from a team as a code owner May 18, 2022 08:42
@MoritzThomasHuebner MoritzThomasHuebner added the ready2merge This PR is ready to be merged (is approved and passes all required checks) label May 18, 2022
xbend
xbend approved these changes May 18, 2022
View reviewed changes
Copy link
Contributor

@xbend xbend left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Domain Proxy part LGTM.

@sebathomas sebathomas removed the ready2merge This PR is ready to be merged (is approved and passes all required checks) label May 18, 2022
nstng
nstng approved these changes May 18, 2022
View reviewed changes
Copy link
Contributor

@nstng nstng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CI changes LGTM

@MoritzThomasHuebner MoritzThomasHuebner force-pushed the Move_orc8r/cloud/go/obsidian_under_orc8r/cloud/go/services branch 4 times, most recently from 3082942 to 7e8509d Compare May 31, 2022 04:58
@MoritzThomasHuebner MoritzThomasHuebner force-pushed the Move_orc8r/cloud/go/obsidian_under_orc8r/cloud/go/services branch 2 times, most recently from 4395989 to 3d248da Compare June 8, 2022 01:55
@MoritzThomasHuebner MoritzThomasHuebner force-pushed the Move_orc8r/cloud/go/obsidian_under_orc8r/cloud/go/services branch from 3d248da to 1becaf0 Compare June 9, 2022 02:01
@voisey voisey requested review from uri200 and removed request for 119Vik, taaraora, electronjoe, hcgatewood, amarpad and uri200 June 13, 2022 08:35
@MoritzThomasHuebner MoritzThomasHuebner force-pushed the Move_orc8r/cloud/go/obsidian_under_orc8r/cloud/go/services branch from 1becaf0 to dcd88bf Compare June 15, 2022 01:45
@pull-request-size pull-request-size bot added size/XL Denotes a Pull Request that changes 500-999 lines. and removed size/L Denotes a Pull Request that changes 100-499 lines. labels Jun 15, 2022
@MoritzThomasHuebner MoritzThomasHuebner force-pushed the Move_orc8r/cloud/go/obsidian_under_orc8r/cloud/go/services branch from dcd88bf to eb922b2 Compare June 17, 2022 00:48
@pull-request-size pull-request-size bot added size/L Denotes a Pull Request that changes 100-499 lines. and removed size/XL Denotes a Pull Request that changes 500-999 lines. labels Jun 17, 2022
@MoritzThomasHuebner MoritzThomasHuebner force-pushed the Move_orc8r/cloud/go/obsidian_under_orc8r/cloud/go/services branch from eb922b2 to f39515a Compare June 22, 2022 05:45
@MoritzThomasHuebner
Copy link
Contributor Author

@uri200 can you have a look at this?

@maxhbr maxhbr changed the title refactor(orc8r): Move cloub/go/obsidian to cloud/go/services refactor(orc8r): Move cloud/go/obsidian to cloud/go/services Jun 23, 2022
@MoritzThomasHuebner MoritzThomasHuebner added the ready2merge This PR is ready to be merged (is approved and passes all required checks) label Jun 23, 2022
@MoritzThomasHuebner
refactor(orc8r): Move cloud/go/obsidian to cloud/go/services
4851518 
Fixes imports of orc8r/cloud/go/obsidian and rearranges imports to be sorted.

Removed obsolete lines in the CODEOWNERS file to pass the respective test.

Used `make fullgen` in "orc8r/docker/cloud" to update "orc8r/docker/cloud/go/services/obsidian/swagger/protos/swagger.pb.go"

Signed-off-by: Moritz Huebner <moritz.huebner@tngtech.com>
@MoritzThomasHuebner MoritzThomasHuebner force-pushed the Move_orc8r/cloud/go/obsidian_under_orc8r/cloud/go/services branch from f39515a to 4851518 Compare June 27, 2022 03:09
@sebathomas sebathomas merged commit be8d0b6 into magma:master Jun 27, 2022
@MoritzThomasHuebner MoritzThomasHuebner deleted the Move_orc8r/cloud/go/obsidian_under_orc8r/cloud/go/services branch July 18, 2022 07:46
emakeev pushed a commit to emakeev/magma that referenced this pull request Aug 5, 2022
@MoritzThomasHuebner @emakeev
refactor(orc8r): Move cloud/go/obsidian to cloud/go/services (magma#1…
ada76f8 
…2742)

Fixes imports of orc8r/cloud/go/obsidian and rearranges imports to be sorted.

Removed obsolete lines in the CODEOWNERS file to pass the respective test.

Used `make fullgen` in "orc8r/docker/cloud" to update "orc8r/docker/cloud/go/services/obsidian/swagger/protos/swagger.pb.go"

Signed-off-by: Moritz Huebner <moritz.huebner@tngtech.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maxhbr maxhbr maxhbr approved these changes

@xbend xbend xbend approved these changes

@ShubhamTatvamasi ShubhamTatvamasi ShubhamTatvamasi approved these changes

@uri200 uri200 uri200 approved these changes

@nstng nstng nstng approved these changes

Assignees
No one assigned
Labels
component: ci All updates on CI (Jenkins/CircleCi/Github Action) component: cwf component: feg FEG-gateway related issues component: orc8r Orchestrator-related issue ready2merge This PR is ready to be merged (is approved and passes all required checks) size/L Denotes a Pull Request that changes 100-499 lines.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@MoritzThomasHuebner @maxhbr @xbend @ShubhamTatvamasi @uri200 @nstng @sebathomas