Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: TODOs for non bazelified c/c++ files are created #12777

Merged
merged 1 commit into from May 18, 2022

Conversation

nstng
Copy link
Contributor

@nstng nstng commented May 18, 2022

Signed-off-by: Nils Semmelrock nils.semmelrock@tngtech.com

Added TODOs as GH issues for c/c++ files that are not yet covered by the bazelification effort. These files are tracked in a deny list that will be cleaned-up step by step.

Summary

Test Plan

CI - there are only changes in comments

Additional Information

  • This change is backwards-breaking

Signed-off-by: Nils Semmelrock <nils.semmelrock@tngtech.com>
@nstng nstng added the bazel changes for the Bazelification effort label May 18, 2022
@nstng nstng self-assigned this May 18, 2022
@nstng nstng requested a review from a team May 18, 2022 14:41
@nstng nstng requested a review from electronjoe May 18, 2022 14:41
@pull-request-size pull-request-size bot added the size/XS Denotes a PR that changes 0-9 lines. label May 18, 2022
@github-actions
Copy link
Contributor

Thanks for opening a PR! 💯

A couple initial guidelines

Howto

  • Reviews. The "Reviewers" listed for this PR are the Magma maintainers who will shepherd it.
  • Checks. All required CI checks must pass before merge.
  • Merge. Once approved and passing CI checks, use the ready2merge label to indicate the maintainers can merge your PR.

More info

Please take a moment to read through the Magma project's

If this is your first Magma PR, also consider reading

@nstng nstng requested review from LKreutzer and removed request for electronjoe May 18, 2022 14:42
@LKreutzer LKreutzer enabled auto-merge (squash) May 18, 2022 15:08
@LKreutzer LKreutzer merged commit 6d9809c into magma:master May 18, 2022
emakeev pushed a commit to emakeev/magma that referenced this pull request Aug 5, 2022
Signed-off-by: Nils Semmelrock <nils.semmelrock@tngtech.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bazel changes for the Bazelification effort size/XS Denotes a PR that changes 0-9 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants