Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(agw): Reduced response wait time to save overall execution time #12781

Conversation

VinashakAnkitAman
Copy link
Member

Title

fix(agw): Reduced response wait time to save overall execution time

Summary

The test cases were taking too much time to come out while waiting for the response messages. This PR reduces the response wait time from 15 minutes to 3 minutes to save overall execution time.

Test plan

Verified with sanity

Signed-off-by: VinashakAnkitAman ankit.aman@radisys.com

Signed-off-by: VinashakAnkitAman <ankit.aman@radisys.com>
Signed-off-by: VinashakAnkitAman <ankit.aman@radisys.com>
@pull-request-size pull-request-size bot added the size/XS Denotes a PR that changes 0-9 lines. label May 19, 2022
@github-actions
Copy link
Contributor

Thanks for opening a PR! 💯

A couple initial guidelines

Howto

  • Reviews. The "Reviewers" listed for this PR are the Magma maintainers who will shepherd it.
  • Checks. All required CI checks must pass before merge.
  • Merge. Once approved and passing CI checks, use the ready2merge label to indicate the maintainers can merge your PR.

More info

Please take a moment to read through the Magma project's

If this is your first Magma PR, also consider reading

@github-actions github-actions bot added the component: agw Access gateway-related issue label May 19, 2022
@github-actions
Copy link
Contributor

github-actions bot commented May 19, 2022

feg-workflow

    2 files  202 suites   38s ⏱️
371 tests 371 ✔️ 0 💤 0
385 runs  385 ✔️ 0 💤 0

Results for commit b06df08.

♻️ This comment has been updated with latest results.

@github-actions
Copy link
Contributor

github-actions bot commented May 19, 2022

dp-workflow

18 tests   18 ✔️  4m 25s ⏱️
  2 suites    0 💤
  2 files      0

Results for commit b06df08.

♻️ This comment has been updated with latest results.

@github-actions
Copy link
Contributor

github-actions bot commented May 19, 2022

agw-workflow

     79 files     124 suites   6m 47s ⏱️
1 153 tests 1 149 ✔️ 4 💤 0
1 155 runs  1 151 ✔️ 4 💤 0

Results for commit b06df08.

♻️ This comment has been updated with latest results.

Signed-off-by: VinashakAnkitAman <ankit.aman@radisys.com>
@netlify
Copy link

netlify bot commented May 20, 2022

👷 Deploy request for competent-euler-513227 pending review.

Visit the deploys page to approve it

Name Link
🔨 Latest commit fbdc408

Signed-off-by: VinashakAnkitAman <ankit.aman@radisys.com>
Signed-off-by: VinashakAnkitAman <ankit.aman@radisys.com>
Signed-off-by: VinashakAnkitAman <ankit.aman@radisys.com>
@VinashakAnkitAman VinashakAnkitAman marked this pull request as ready for review May 25, 2022 23:20
@VinashakAnkitAman VinashakAnkitAman requested a review from a team May 25, 2022 23:20
Signed-off-by: VinashakAnkitAman <ankit.aman@radisys.com>
Signed-off-by: VinashakAnkitAman <ankit.aman@radisys.com>
Signed-off-by: VinashakAnkitAman <ankit.aman@radisys.com>
Signed-off-by: VinashakAnkitAman <ankit.aman@radisys.com>
@ardzoht ardzoht merged commit 0b7c452 into magma:master Jun 23, 2022
emakeev pushed a commit to emakeev/magma that referenced this pull request Aug 5, 2022
…agma#12781)

* fix(agw): Reduced response wait time to save overall execution time

Signed-off-by: VinashakAnkitAman <ankit.aman@radisys.com>

* Updated the comment

Signed-off-by: VinashakAnkitAman <ankit.aman@radisys.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: agw Access gateway-related issue size/XS Denotes a PR that changes 0-9 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants