Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(lte): Remove unused lte crypto & switch to magma/milenage pkg #12809

Merged
merged 1 commit into from May 20, 2022

Conversation

emakeev
Copy link
Contributor

@emakeev emakeev commented May 20, 2022

Signed-off-by: Evgeniy Makeev evgeniym@fb.com

Summary

Remove unused lte crypto & switch to independent magma/milenage package

Test Plan

unit tests

Additional Information

  • This change is backwards-breaking

@emakeev emakeev requested review from a team and uri200 May 20, 2022 20:49
@pull-request-size pull-request-size bot added the size/XXL Denotes a Pull Request that changes 1000+ lines. label May 20, 2022
@github-actions
Copy link
Contributor

Thanks for opening a PR! 💯

A couple initial guidelines

Howto

  • Reviews. The "Reviewers" listed for this PR are the Magma maintainers who will shepherd it.
  • Checks. All required CI checks must pass before merge.
  • Merge. Once approved and passing CI checks, use the ready2merge label to indicate the maintainers can merge your PR.

More info

Please take a moment to read through the Magma project's

If this is your first Magma PR, also consider reading

@github-actions github-actions bot added the component: orc8r Orchestrator-related issue label May 20, 2022
@emakeev emakeev requested review from ssanadhya and ardzoht May 20, 2022 20:50
@github-actions
Copy link
Contributor

github-actions bot commented May 20, 2022

feg-workflow

    2 files  202 suites   38s ⏱️
371 tests 371 ✔️ 0 💤 0
385 runs  385 ✔️ 0 💤 0

Results for commit d92612c.

♻️ This comment has been updated with latest results.

Signed-off-by: Evgeniy Makeev <evgeniym@fb.com>
@emakeev emakeev requested review from a team May 20, 2022 21:06
@github-actions github-actions bot added component: cwf component: feg FEG-gateway related issues labels May 20, 2022
@github-actions
Copy link
Contributor

dp-workflow

  2 files    2 suites   3m 19s ⏱️
15 tests 15 ✔️ 0 💤 0

Results for commit d92612c.

@github-actions
Copy link
Contributor

github-actions bot commented May 20, 2022

cloud-workflow

    7 files  355 suites   2m 10s ⏱️
942 tests 942 ✔️ 0 💤 0

Results for commit d92612c.

♻️ This comment has been updated with latest results.

@github-actions
Copy link
Contributor

agw-workflow

     77 files     122 suites   7m 4s ⏱️
1 159 tests 1 155 ✔️ 4 💤 0
1 160 runs  1 156 ✔️ 4 💤 0

Results for commit d92612c.

@emakeev emakeev merged commit 2f875d4 into magma:master May 20, 2022
@emakeev emakeev deleted the remove_unused_lte_crypto branch August 5, 2022 23:11
emakeev added a commit to emakeev/magma that referenced this pull request Aug 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: cwf component: feg FEG-gateway related issues component: orc8r Orchestrator-related issue size/XXL Denotes a Pull Request that changes 1000+ lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants