New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Remove references to roles/ovs_* #12820
Merged
jheidbrink
merged 1 commit into
magma:master
from
jheidbrink:remove_outdated_references_packer
Jun 1, 2022
Merged
chore: Remove references to roles/ovs_* #12820
jheidbrink
merged 1 commit into
magma:master
from
jheidbrink:remove_outdated_references_packer
Jun 1, 2022
+0
−21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Thanks for opening a PR! 💯
Howto
More infoPlease take a moment to read through the Magma project's
If this is your first Magma PR, also consider reading
|
github-actions
bot
added
the
component: ci
All updates on CI (Jenkins/CircleCi/Github Action)
label
May 23, 2022
Neudrino
approved these changes
May 24, 2022
voisey
approved these changes
May 31, 2022
maxhbr
approved these changes
Jun 1, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
These were removed in f346022 Signed-off-by: Jan Heidbrink <jan.heidbrink@tngtech.com>
jheidbrink
force-pushed
the
remove_outdated_references_packer
branch
from
June 1, 2022 06:20
866abc5
to
177e210
Compare
emakeev
pushed a commit
to emakeev/magma
that referenced
this pull request
Aug 5, 2022
These were removed in f346022 Signed-off-by: Jan Heidbrink <jan.heidbrink@tngtech.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
component: ci
All updates on CI (Jenkins/CircleCi/Github Action)
size/S
Denotes a PR that changes 10-29 lines.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Removes references to files which were removed in f346022 from Packer definitions. This is needed in order to build the VMs with Packer.
Test Plan
Build magma-focal-virtualbox.json with Packer