Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Remove references to roles/ovs_* #12820

Merged

Conversation

jheidbrink
Copy link
Contributor

Summary

Removes references to files which were removed in f346022 from Packer definitions. This is needed in order to build the VMs with Packer.

Test Plan

Build magma-focal-virtualbox.json with Packer

@jheidbrink jheidbrink requested review from a team and emakeev May 23, 2022 13:12
@pull-request-size pull-request-size bot added the size/S Denotes a PR that changes 10-29 lines. label May 23, 2022
@github-actions
Copy link
Contributor

Thanks for opening a PR! 💯

A couple initial guidelines

Howto

  • Reviews. The "Reviewers" listed for this PR are the Magma maintainers who will shepherd it.
  • Checks. All required CI checks must pass before merge.
  • Merge. Once approved and passing CI checks, use the ready2merge label to indicate the maintainers can merge your PR.

More info

Please take a moment to read through the Magma project's

If this is your first Magma PR, also consider reading

@github-actions github-actions bot added the component: ci All updates on CI (Jenkins/CircleCi/Github Action) label May 23, 2022
@github-actions
Copy link
Contributor

github-actions bot commented May 23, 2022

feg-workflow

    2 files  202 suites   37s ⏱️
371 tests 371 ✔️ 0 💤 0
385 runs  385 ✔️ 0 💤 0

Results for commit 177e210.

♻️ This comment has been updated with latest results.

@github-actions
Copy link
Contributor

github-actions bot commented May 23, 2022

dp-workflow

  2 files    2 suites   3m 44s ⏱️
15 tests 15 ✔️ 0 💤 0

Results for commit 177e210.

♻️ This comment has been updated with latest results.

@github-actions
Copy link
Contributor

github-actions bot commented May 23, 2022

cloud-workflow

    7 files  355 suites   2m 7s ⏱️
979 tests 979 ✔️ 0 💤 0

Results for commit 177e210.

♻️ This comment has been updated with latest results.

@github-actions
Copy link
Contributor

github-actions bot commented May 23, 2022

agw-workflow

     77 files     122 suites   6m 22s ⏱️
1 151 tests 1 147 ✔️ 4 💤 0
1 152 runs  1 148 ✔️ 4 💤 0

Results for commit 177e210.

♻️ This comment has been updated with latest results.

Copy link
Member

@maxhbr maxhbr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

These were removed in f346022

Signed-off-by: Jan Heidbrink <jan.heidbrink@tngtech.com>
@jheidbrink jheidbrink force-pushed the remove_outdated_references_packer branch from 866abc5 to 177e210 Compare June 1, 2022 06:20
@jheidbrink jheidbrink enabled auto-merge (squash) June 1, 2022 06:20
@jheidbrink jheidbrink merged commit 43a3da2 into magma:master Jun 1, 2022
@jheidbrink jheidbrink deleted the remove_outdated_references_packer branch June 27, 2022 16:03
emakeev pushed a commit to emakeev/magma that referenced this pull request Aug 5, 2022
These were removed in f346022

Signed-off-by: Jan Heidbrink <jan.heidbrink@tngtech.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: ci All updates on CI (Jenkins/CircleCi/Github Action) size/S Denotes a PR that changes 10-29 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants