refactor(orc8r): move GetControlProxy to tenants #12827
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pull-request-size
bot
added
the
size/L
|
Thanks for opening a PR! 💯
Howto
More infoPlease take a moment to read through the Magma project's
If this is your first Magma PR, also consider reading
|
wolfseb
force-pushed
the
move_control_proxy_from_networkid_to_tenants
branch
8 times, most recently
from
d2e5105
to
dd75928
Compare
sebathomas
reviewed
May 25, 2022
orc8r/cloud/go/services/bootstrapper/servicers/registration/registration.go
Show resolved
Hide resolved
orc8r/cloud/go/services/tenants/servicers/protected/servicer_test.go
Outdated
Show resolved
Hide resolved
orc8r/cloud/go/services/tenants/servicers/protected/servicer_test.go
Outdated
Show resolved
Hide resolved
orc8r/cloud/go/services/tenants/servicers/protected/servicer_test.go
Outdated
Show resolved
Hide resolved
orc8r/cloud/go/services/tenants/servicers/protected/servicer_test.go
Outdated
Show resolved
Hide resolved
wolfseb
force-pushed
the
move_control_proxy_from_networkid_to_tenants
branch
from
dd75928
to
1c81c47
Compare
wolfseb
force-pushed
the
move_control_proxy_from_networkid_to_tenants
branch
3 times, most recently
from
f46066b
to
5e29472
Compare
sebathomas
approved these changes
May 30, 2022
wolfseb
force-pushed
the
move_control_proxy_from_networkid_to_tenants
branch
4 times, most recently
from
e0b0aa4
to
0efaad6
Compare
maxhbr
reviewed
Jun 7, 2022
| if n == request.GetNetworkID() { | ||
| tenantID = t.Id | ||
| isTenantFound = true | ||
| break |
There was a problem hiding this comment.
I am never sure how a break that is in two nested loops behaves. Can you make that clearer here?
There was a problem hiding this comment.
I moved the loops into a separate function to resolve this issue.
wolfseb
force-pushed
the
move_control_proxy_from_networkid_to_tenants
branch
from
0efaad6
to
418ece8
Compare
wolfseb
force-pushed
the
move_control_proxy_from_networkid_to_tenants
branch
from
418ece8
to
75b5ea1
Compare
Create a function `GetControlProxyFromNetworkID` in tenants to take over the functionality of `GetControlProxy` in registration. Create the corresponding tests in tenants and adjust the tests in registration to use the proper service calls. Signed-off-by: Sebastian Wolf <sebastian.wolf@tngtech.com>
wolfseb
force-pushed
the
move_control_proxy_from_networkid_to_tenants
branch
from
75b5ea1
to
6323fa6
Compare
sebathomas
approved these changes
Jun 9, 2022
emakeev
pushed a commit
to emakeev/magma
that referenced
this pull request
Aug 5, 2022
Create a function `GetControlProxyFromNetworkID` in tenants to take over the functionality of `GetControlProxy` in registration. Create the corresponding tests in tenants and adjust the tests in registration to use the proper service calls. Signed-off-by: Sebastian Wolf <sebastian.wolf@tngtech.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Sebastian Wolf sebastian.wolf@tngtech.com
Summary
Create a function
GetControlProxyFromNetworkIDin tenants to take overthe functionality of
GetControlProxyin registration. Create the correspondingtests in tenants and adjust the tests in registration to use the proper service calls.
Test Plan
Perform unit tests.
Additional Information
Created in pairing with @MoritzThomasHuebner and @sebathomas