Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ci):Revert all registry change #12841

Closed
wants to merge 5 commits into from
Closed

fix(ci):Revert all registry change #12841

wants to merge 5 commits into from

Conversation

tmdzk
Copy link
Collaborator

@tmdzk tmdzk commented May 25, 2022

fix(ci):Revert all registry change

Summary

Revert "Fix dockerfile build agw (https://github.com/magma/magma/pull/12836[)"](https://github.com/magma/magma/commit/aaf7452d3efb258a19c4d76401f85264defcd64f)

backport-bot committed 2 minutes ago

Revert "fix(ci): fix problems with switch from fb to magma artifactory …

backport-bot committed 2 minutes ago

Revert "Revert "Revert "Revert "Revert "fix(deps): Fixing CPU architehttps://github.com//pull/12687

backport-bot committed 1 minute ago

Revert "feat(cleanup):bump ubuntu from 18(bionic) to 20(focal) (#12688)"

backport-bot committed 1 minute ago

Revert "fix(agw): Get rid of old registries (#12549) (#12558) (#12689)"

backport-bot committed 16 seconds ago

Test Plan

backport-bot added 5 commits May 25, 2022 06:38
@tmdzk tmdzk requested a review from a team May 25, 2022 10:40
@tmdzk tmdzk requested a review from a team as a code owner May 25, 2022 10:40
@tmdzk tmdzk requested review from a team, 119Vik and uri200 May 25, 2022 10:40
@pull-request-size pull-request-size bot added the size/XL Denotes a Pull Request that changes 500-999 lines. label May 25, 2022
@github-actions
Copy link
Contributor

Thanks for opening a PR! 💯

A couple initial guidelines

Howto

  • Reviews. The "Reviewers" listed for this PR are the Magma maintainers who will shepherd it.
  • Checks. All required CI checks must pass before merge.
  • Merge. Once approved and passing CI checks, use the ready2merge label to indicate the maintainers can merge your PR.

More info

Please take a moment to read through the Magma project's

If this is your first Magma PR, also consider reading

@github-actions github-actions bot added component: ci All updates on CI (Jenkins/CircleCi/Github Action) component: cwf component: feg FEG-gateway related issues component: orc8r Orchestrator-related issue labels May 25, 2022
github-actions[bot]
github-actions bot reviewed May 25, 2022
View reviewed changes
.devcontainer/Dockerfile
rm -rf /tmp/*
### install python3-aioeventlet and bcc-tools from the magma apt repo
COPY orc8r/tools/ansible/roles/pkgrepo/files/jfrog.pub /tmp/
RUN apt-key add /tmp/jfrog.pub && \
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

📝 [hadolint] <DL3015> reported by reviewdog 🐶
Avoid additional packages by specifying --no-install-recommends

.devcontainer/Dockerfile
rm -rf /tmp/*
### install python3-aioeventlet and bcc-tools from the magma apt repo
COPY orc8r/tools/ansible/roles/pkgrepo/files/jfrog.pub /tmp/
RUN apt-key add /tmp/jfrog.pub && \
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ [hadolint] <DL3008> reported by reviewdog 🐶
Pin versions in apt get install. Instead of apt-get install <package> use apt-get install <package>=<version>

experimental/bazel-base/Dockerfile
# MAGMA_ROOT is needed by python tests (e.g. freedomfi_one_tests in enodebd)
ENV MAGMA_ROOT=/magma

RUN apt-get update && \
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ [hadolint] <DL3008> reported by reviewdog 🐶
Pin versions in apt get install. Instead of apt-get install <package> use apt-get install <package>=<version>

experimental/bazel-base/Dockerfile
# MAGMA_ROOT is needed by python tests (e.g. freedomfi_one_tests in enodebd)
ENV MAGMA_ROOT=/magma

RUN apt-get update && \
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

📝 [hadolint] <DL3009> reported by reviewdog 🐶
Delete the apt-get lists after installing something

experimental/bazel-base/Dockerfile

# Install depencies from facebook repository
COPY orc8r/tools/ansible/roles/pkgrepo/files/jfrog.pub /tmp/
RUN apt-key add /tmp/jfrog.pub && \
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ [hadolint] <DL3008> reported by reviewdog 🐶
Pin versions in apt get install. Instead of apt-get install <package> use apt-get install <package>=<version>

experimental/bazel-base/Dockerfile

##### FreeDiameter
COPY lte/gateway/c/core/oai/patches/ /tmp/
RUN git clone https://github.com/OPENAIRINTERFACE/opencord.org.freeDiameter.git freediameter && \
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ [hadolint] <DL3003> reported by reviewdog 🐶
Use WORKDIR to switch to a directory

experimental/bazel-base/Dockerfile
# Update shared library configuration
RUN ldconfig -v

RUN ln -s /magma/bazel/bazelrcs/docker.bazelrc /etc/bazelrc
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

📝 [hadolint] <DL3059> reported by reviewdog 🐶
Multiple consecutive RUN instructions. Consider consolidation.

lte/gateway/docker/services/c/Dockerfile
openvswitch-common \
openvswitch-switch

RUN apt-get update && apt-get install -y libopenvswitch openvswitch-datapath-dkms openvswitch-common openvswitch-switch
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ [hadolint] <DL3008> reported by reviewdog 🐶
Pin versions in apt get install. Instead of apt-get install <package> use apt-get install <package>=<version>

lte/gateway/docker/services/c/Dockerfile
openvswitch-common \
openvswitch-switch

RUN apt-get update && apt-get install -y libopenvswitch openvswitch-datapath-dkms openvswitch-common openvswitch-switch
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

📝 [hadolint] <DL3015> reported by reviewdog 🐶
Avoid additional packages by specifying --no-install-recommends

lte/gateway/docker/services/c/Dockerfile
openvswitch-common \
openvswitch-switch

RUN apt-get update && apt-get install -y libopenvswitch openvswitch-datapath-dkms openvswitch-common openvswitch-switch
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

📝 [hadolint] <DL3009> reported by reviewdog 🐶
Delete the apt-get lists after installing something

github-actions[bot]
github-actions bot reviewed May 25, 2022
View reviewed changes
orc8r/tools/ansible/roles/pkgrepo/tasks/debian.yml
# limitations under the License.
################################################################################
- name: Ensure ca-certificates is up to date
become: yes
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[yamllint] reported by reviewdog 🐶
[warning] truthy value should be one of [false, true] (truthy)

orc8r/tools/ansible/roles/pkgrepo/tasks/debian.yml
become: yes
apt:
name: "{{ packages }}"
only_upgrade: yes
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[yamllint] reported by reviewdog 🐶
[warning] truthy value should be one of [false, true] (truthy)

orc8r/tools/ansible/roles/pkgrepo/tasks/debian.yml

- name: Remove old magma etagecom sources
shell: rm -rf /etc/apt/sources.list.d/packages_magma_etagecom_io.list
become: yes
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[yamllint] reported by reviewdog 🐶
[warning] truthy value should be one of [false, true] (truthy)

orc8r/tools/ansible/roles/pkgrepo/tasks/debian.yml
- name: Remove old magma etagecom sources
shell: rm -rf /etc/apt/sources.list.d/packages_magma_etagecom_io.list
become: yes
ignore_errors: yes
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[yamllint] reported by reviewdog 🐶
[warning] truthy value should be one of [false, true] (truthy)

orc8r/tools/ansible/roles/pkgrepo/tasks/debian.yml
- name: Add JFrog repo
apt_repository:
repo: 'deb https://facebookconnectivity.jfrog.io/artifactory/list/{{ repo }}/ {{ distribution }} main'
update_cache: yes
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[yamllint] reported by reviewdog 🐶
[warning] truthy value should be one of [false, true] (truthy)

orc8r/tools/ansible/roles/pkgrepo/tasks/main.yml
state: present
- name: remove fluentbit repo as its broken
shell: rm -rf /etc/apt/sources.list.d/packages_fluentbit_io_ubuntu_focal.list
become: yes
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[yamllint] reported by reviewdog 🐶
[warning] truthy value should be one of [false, true] (truthy)

orc8r/tools/ansible/roles/pkgrepo/tasks/main.yml
- name: remove fluentbit repo as its broken
shell: rm -rf /etc/apt/sources.list.d/packages_fluentbit_io_ubuntu_focal.list
become: yes
ignore_errors: yes
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[yamllint] reported by reviewdog 🐶
[warning] truthy value should be one of [false, true] (truthy)

@github-actions
Copy link
Contributor

Oops! Looks like you failed the DCO check. Be sure to sign all your commits.

Howto

@github-actions
Copy link
Contributor

feg-workflow

    2 files  202 suites   37s ⏱️
371 tests 371 ✔️ 0 💤 0 ❌
385 runs  385 ✔️ 0 💤 0 ❌

Results for commit 07c5e59.

@Neudrino Neudrino requested a review from nstng May 25, 2022 10:54
@github-actions
Copy link
Contributor

dp-workflow

  2 files    2 suites   3m 57s ⏱️
15 tests 15 ✔️ 0 💤 0 ❌

Results for commit 07c5e59.

@github-actions
Copy link
Contributor

cloud-workflow

    7 files  354 suites   2m 7s ⏱️
949 tests 949 ✔️ 0 💤 0 ❌

Results for commit 07c5e59.

@nstng
Copy link
Contributor

nstng commented May 25, 2022

@tmdzk the .devcontainer changes need to stay on the master version - there were some changes in between. these files should not be affected by thi artifactory migration. This is, for this PR please:

  • no changes in .devcontainer/Dockerfile
  • keep experimental/bazel-base/Dockerfiles removed

@github-actions
Copy link
Contributor

agw-workflow

  75 files  120 suites   3m 9s ⏱️
572 tests 572 ✔️ 0 💤 0 ❌

Results for commit 07c5e59.

@Neudrino
Copy link
Contributor

Neudrino commented Jun 9, 2022 •
edited

Relates to:

@tmdzk
Copy link
Collaborator Author

tmdzk commented Jun 9, 2022

this is not needed anymore

@tmdzk tmdzk closed this Jun 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions github-actions[bot] github-actions left review comments

@119Vik 119Vik Awaiting requested review from 119Vik 119Vik was automatically assigned from magma/approvers-ci

@uri200 uri200 Awaiting requested review from uri200

@nstng nstng Awaiting requested review from nstng

Assignees
No one assigned
Labels
component: ci All updates on CI (Jenkins/CircleCi/Github Action) component: cwf component: feg FEG-gateway related issues component: orc8r Orchestrator-related issue size/XL Denotes a Pull Request that changes 500-999 lines.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@tmdzk @nstng @Neudrino