Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(dp): Make target with tests development POD #12876

Merged
merged 1 commit into from Jun 1, 2022

Conversation

sklgromek
Copy link
Contributor

Signed-off-by: Tomasz Gromowski tomasz@freedomfi.com

Add make target which will leave test-runner POD,
for local tests running/debugging.

Summary

Test Plan

Additional Information

  • This change is backwards-breaking

@sklgromek sklgromek requested review from a team and m-trojanowski May 30, 2022 13:59
@pull-request-size pull-request-size bot added the size/M Denotes a PR that changes 30-99 lines. label May 30, 2022
@sklgromek sklgromek removed the request for review from m-trojanowski May 30, 2022 13:59
@github-actions
Copy link
Contributor

Thanks for opening a PR! 💯

A couple initial guidelines

Howto

  • Reviews. The "Reviewers" listed for this PR are the Magma maintainers who will shepherd it.
  • Checks. All required CI checks must pass before merge.
  • Merge. Once approved and passing CI checks, use the ready2merge label to indicate the maintainers can merge your PR.

More info

Please take a moment to read through the Magma project's

If this is your first Magma PR, also consider reading

@sklgromek sklgromek requested a review from xbend May 30, 2022 13:59
@github-actions github-actions bot added component: dp All updates to Domain Proxy dp module component: orc8r Orchestrator-related issue labels May 30, 2022
@sklgromek sklgromek requested review from jkmar and WojSad May 30, 2022 14:00
@github-actions
Copy link
Contributor

github-actions bot commented May 30, 2022

dp-workflow

  2 files    2 suites   3m 15s ⏱️
15 tests 15 ✔️ 0 💤 0

Results for commit a7b2907.

♻️ This comment has been updated with latest results.

dp/tools/deployment/tests/test_runner_deployment_dev.yml Outdated Show resolved Hide resolved
.dockerignore Show resolved Hide resolved
Signed-off-by: Tomasz Gromowski <tomasz@freedomfi.com>
@sklgromek sklgromek force-pushed the dp-test-runner-debug-target branch from 180c7a8 to a7b2907 Compare May 31, 2022 13:46
@sklgromek sklgromek merged commit 4fb862f into magma:master Jun 1, 2022
emakeev pushed a commit to emakeev/magma that referenced this pull request Aug 5, 2022
Signed-off-by: Tomasz Gromowski <tomasz@freedomfi.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: dp All updates to Domain Proxy dp module component: orc8r Orchestrator-related issue size/M Denotes a PR that changes 30-99 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants