Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: updated url for go installation #12879

Merged
merged 1 commit into from May 31, 2022

Conversation

ajahl
Copy link
Contributor

@ajahl ajahl commented May 31, 2022

Signed-off-by: Alex Jahl alexander.jahl@tngtech.com

Summary

As introduced in #12605 , only the Go version from https://artifactory.magmacore.org/artifactory should be used. The PR updates the installation guide.

Test Plan

Additional Information

  • This change is backwards-breaking

Signed-off-by: Alex Jahl <alexander.jahl@tngtech.com>
@pull-request-size pull-request-size bot added the size/XS Denotes a PR that changes 0-9 lines. label May 31, 2022
@github-actions
Copy link
Contributor

Thanks for opening a PR! 💯

A couple initial guidelines

Howto

  • Reviews. The "Reviewers" listed for this PR are the Magma maintainers who will shepherd it.
  • Checks. All required CI checks must pass before merge.
  • Merge. Once approved and passing CI checks, use the ready2merge label to indicate the maintainers can merge your PR.

More info

Please take a moment to read through the Magma project's

If this is your first Magma PR, also consider reading

@github-actions github-actions bot added the component: docs Documentation-related issue label May 31, 2022
@ajahl ajahl marked this pull request as ready for review May 31, 2022 08:39
@ajahl ajahl requested review from a team and Neudrino May 31, 2022 08:39
Copy link
Contributor

@Neudrino Neudrino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was the go update actually merged before the 1.7 release?
If so, the versioned documentation for v1.7 should also be updated.

Copy link
Contributor

@Neudrino Neudrino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If not, the change looks good to me.

@ajahl
Copy link
Contributor Author

ajahl commented May 31, 2022

Was the go update actually merged before the 1.7 release? If so, the versioned documentation for v1.7 should also be updated.

The Go 1.18 upgrade is not part of 1.7.

@ajahl ajahl merged commit 53842ca into magma:master May 31, 2022
mpfirrmann pushed a commit to mpfirrmann/magma that referenced this pull request May 31, 2022
Signed-off-by: Alex Jahl <alexander.jahl@tngtech.com>
emakeev pushed a commit to emakeev/magma that referenced this pull request Aug 5, 2022
Signed-off-by: Alex Jahl <alexander.jahl@tngtech.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: docs Documentation-related issue size/XS Denotes a PR that changes 0-9 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants