Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(dp): Show timestamps in integrations_tests #12881

Merged
merged 1 commit into from Jun 3, 2022
Merged

chore(dp): Show timestamps in integrations_tests #12881

merged 1 commit into from Jun 3, 2022

Conversation

sklgromek
Copy link
Contributor

@sklgromek sklgromek commented May 31, 2022 •
edited

Signed-off-by: Tomasz Gromowski tomasz@freedomfi.com

Summary

Add timestamps to test_runner output and logs

Test Plan

  • Creating this PR
  • Check if in dp-workflow summary logs saved as artifacts have timestamps

@sklgromek sklgromek requested a review from a team May 31, 2022 10:55
@sklgromek sklgromek requested a review from a team as a code owner May 31, 2022 10:55
@sklgromek sklgromek requested review from taaraora and nstng May 31, 2022 10:55
@pull-request-size pull-request-size bot added the size/S Denotes a PR that changes 10-29 lines. label May 31, 2022
@github-actions
Copy link
Contributor

Thanks for opening a PR! 💯

A couple initial guidelines

Howto

  • Reviews. The "Reviewers" listed for this PR are the Magma maintainers who will shepherd it.
  • Checks. All required CI checks must pass before merge.
  • Merge. Once approved and passing CI checks, use the ready2merge label to indicate the maintainers can merge your PR.

More info

Please take a moment to read through the Magma project's

If this is your first Magma PR, also consider reading

@github-actions github-actions bot added component: ci All updates on CI (Jenkins/CircleCi/Github Action) component: dp All updates to Domain Proxy dp module component: orc8r Orchestrator-related issue labels May 31, 2022
Neudrino
Neudrino approved these changes May 31, 2022
View reviewed changes
Copy link
Contributor

@Neudrino Neudrino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems reasonable.

Was it tested?
Give a test plan in the PR description and execute it 😉, please.

@github-actions
Copy link
Contributor

github-actions bot commented May 31, 2022 •
edited

dp-workflow

  2 files    2 suites   3m 9s ⏱️
15 tests 15 ✔️ 0 💤 0 ❌

Results for commit 71d4fc0.

♻️ This comment has been updated with latest results.

@sklgromek sklgromek force-pushed the dp-testrunner-timestamps branch 2 times, most recently from b4f92d1 to e220c02 Compare June 1, 2022 11:08
@pull-request-size pull-request-size bot added size/XS Denotes a PR that changes 0-9 lines. and removed size/S Denotes a PR that changes 10-29 lines. labels Jun 1, 2022
@github-actions github-actions bot removed the component: orc8r Orchestrator-related issue label Jun 1, 2022
@pull-request-size pull-request-size bot added size/S Denotes a PR that changes 10-29 lines. and removed size/XS Denotes a PR that changes 0-9 lines. labels Jun 2, 2022
@sklgromek
chore(dp): Show timestamps in integrations_tests
71d4fc0 
Signed-off-by: Tomasz Gromowski <tomasz@freedomfi.com>
@github-actions github-actions bot added the component: orc8r Orchestrator-related issue label Jun 2, 2022
@xbend xbend merged commit 2a05ffd into magma:master Jun 3, 2022
@xbend xbend deleted the dp-testrunner-timestamps branch June 3, 2022 10:14
emakeev pushed a commit to emakeev/magma that referenced this pull request Aug 5, 2022
@sklgromek @emakeev
chore(dp): Show timestamps in integrations_tests (magma#12881)
c02a70c 
Add timestamps to test_runner output and logs.

Signed-off-by: Tomasz Gromowski <tomasz@freedomfi.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Neudrino Neudrino Neudrino approved these changes

@jkmar jkmar jkmar approved these changes

@WojSad WojSad WojSad approved these changes

@taaraora taaraora Awaiting requested review from taaraora

@nstng nstng Awaiting requested review from nstng nstng was automatically assigned from magma/approvers-ci

Assignees
No one assigned
Labels
component: ci All updates on CI (Jenkins/CircleCi/Github Action) component: dp All updates to Domain Proxy dp module component: orc8r Orchestrator-related issue size/S Denotes a PR that changes 10-29 lines.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@sklgromek @Neudrino @jkmar @WojSad @xbend