Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Update orc8r minikube deployment docs to account for Linux #12889

Merged
merged 1 commit into from Jun 1, 2022

Conversation

voisey
Copy link
Contributor

@voisey voisey commented May 31, 2022

Summary

At present, this page https://docs.magmacore.org/docs/orc8r/dev_minikube is mac-specific. However, the instructions therein were recently followed successfully on Linux, so this updates the page to include Linux-specific instructions too.

Test Plan

  • cd magma/docs && make precommit

Signed-off-by: Cameron Voisey <cameron.voisey@tngtech.com>
@voisey voisey requested review from a team and Neudrino May 31, 2022 16:39
@pull-request-size pull-request-size bot added the size/S Denotes a PR that changes 10-29 lines. label May 31, 2022
@github-actions
Copy link
Contributor

Thanks for opening a PR! 💯

A couple initial guidelines

Howto

  • Reviews. The "Reviewers" listed for this PR are the Magma maintainers who will shepherd it.
  • Checks. All required CI checks must pass before merge.
  • Merge. Once approved and passing CI checks, use the ready2merge label to indicate the maintainers can merge your PR.

More info

Please take a moment to read through the Magma project's

If this is your first Magma PR, also consider reading

@github-actions github-actions bot added the component: docs Documentation-related issue label May 31, 2022
@voisey
Copy link
Contributor Author

voisey commented May 31, 2022

@sebathomas @ajahl @mpfirrmann @crasu @alexzurbonsen I believe you may have used these docs recently, so please feel free to contribute if you think they can be further improved

@voisey voisey merged commit bad727f into magma:master Jun 1, 2022
emakeev pushed a commit to emakeev/magma that referenced this pull request Aug 5, 2022
…ma#12889)

Signed-off-by: Cameron Voisey <cameron.voisey@tngtech.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: docs Documentation-related issue size/S Denotes a PR that changes 10-29 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants