New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(dp): Use mutable installation params for mutable cbsd API #12891

Merged

jkmar merged 1 commit into magma:master from openEPC:cbsd_api_validation

Jun 2, 2022

Contributor

jkmar commented Jun 1, 2022

Summary

Previously same models were used for both mutable and read API,
but users should only be able to edit certain fields (antenna gain).

Signed-off-by: Kuba Marciniszyn kuba@freedomfi.com

jkmar requested review from WojSad and a team

June 1, 2022 09:50

pull-request-size bot added the size/L label

Contributor

github-actions bot commented Jun 1, 2022

Thanks for opening a PR! 💯

A couple initial guidelines

All commits must be signed off. This is enforced by DCO check.
All PR titles must follow the semantic commits format. This is enforced by Semantic PR.

Howto

Reviews. The "Reviewers" listed for this PR are the Magma maintainers who will shepherd it.
Checks. All required CI checks must pass before merge.
Merge. Once approved and passing CI checks, use the ready2merge label to indicate the maintainers can merge your PR.

More info

Please take a moment to read through the Magma project's

Contributing Conventions for norms around contributed code

If this is your first Magma PR, also consider reading

Developer Onboarding for onboarding as a new Magma developer
Development Workflow for guidance on your first pull request
CI Checks for points of contact for failing or flaky CI checks
GitHub-to-Slack mappings for Magma maintainers for guidance on how to contact maintainers on Slack

github-actions bot added component: nms component: orc8r labels

Contributor

github-actions bot commented Jun 1, 2022 •

edited

feg-workflow

    2 files 202 suites 38s ⏱️
371 tests 371 ✔️ 0 💤 0 ❌
385 runs 385 ✔️ 0 💤 0 ❌

Results for commit c154582.

♻️ This comment has been updated with latest results.

Contributor

github-actions bot commented Jun 1, 2022 •

edited

nms-workflow

0 files 0 suites 0s ⏱️
0 tests 0 ✔️ 0 💤 0 ❌

Results for commit c154582.

♻️ This comment has been updated with latest results.

Contributor

github-actions bot commented Jun 1, 2022 •

edited

dp-workflow

  2 files   2 suites 3m 38s ⏱️
15 tests 15 ✔️ 0 💤 0 ❌

Results for commit c154582.

♻️ This comment has been updated with latest results.

Contributor

github-actions bot commented Jun 1, 2022 •

edited

cloud-workflow

    7 files 355 suites 2m 8s ⏱️
978 tests 978 ✔️ 0 💤 0 ❌

Results for commit c154582.

♻️ This comment has been updated with latest results.

Contributor

github-actions bot commented Jun 1, 2022 •

edited

agw-workflow

    77 files   122 suites 6m 23s ⏱️
1 151 tests 1 147 ✔️ 4 💤 0 ❌
1 152 runs 1 148 ✔️ 4 💤 0 ❌

Results for commit c154582.

♻️ This comment has been updated with latest results.

jkmar force-pushed the cbsd_api_validation branch from ad53f55 to 3815f12 Compare

June 1, 2022 11:13


          feat(dp): Use mutable installation params for mutable cbsd API

c154582

Previously same models were used for both mutable and read API,
but users should only be able to edit certain fields (antenna gain).

Signed-off-by: Kuba Marciniszyn <kuba@freedomfi.com>

jkmar force-pushed the cbsd_api_validation branch from 3815f12 to c154582 Compare

June 1, 2022 11:16

WojSad approved these changes

View reviewed changes

jkmar merged commit 48a2260 into magma:master

emakeev pushed a commit to emakeev/magma that referenced this pull request


          feat(dp): Use mutable installation params for mutable cbsd API (magma…

e692a9b

…#12891)

Previously same models were used for both mutable and read API,
but users should only be able to edit certain fields (antenna gain).

Signed-off-by: Kuba Marciniszyn <kuba@freedomfi.com>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment