Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test(mme): Additional tests for ipv6 data #12892

Merged
merged 17 commits into from
Aug 11, 2022
Merged

test(mme): Additional tests for ipv6 data #12892

merged 17 commits into from
Aug 11, 2022

Conversation

pruthvihebbani
Copy link
Contributor

@pruthvihebbani pruthvihebbani commented Jun 1, 2022 •
edited

Signed-off-by: Pruthvi Hebbani pruthvi.hebbani@radisys.com

test(mme): Additional tests for ipv6 data

Summary

Added ipv6 with dedicated bearer and ipv4v6 tests with UL TCP data

Test Plan

Verified that the tests pass successfully on multiple runs and data is flowing through the desired bearer

ipv6 ul tcp data working test vm

ipv6 dl tcp data working test vm

ipv4v6 ul tcp data working test vm

ipv4v6 ul tcp data with ded br working test vm

ipv4v6 dl tcp data with ded br working test vm

@pruthvihebbani
test(mme): Additional tests for ipv6 data
1c8a6fb 
Signed-off-by: Pruthvi Hebbani <pruthvi.hebbani@radisys.com>
@pruthvihebbani pruthvihebbani requested review from a team and rsarwad June 1, 2022 10:12
@pull-request-size pull-request-size bot added the size/L Denotes a Pull Request that changes 100-499 lines. label Jun 1, 2022
@github-actions github-actions bot added the component: agw Access gateway-related issue label Jun 1, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Jun 1, 2022

Thanks for opening a PR! 💯

A couple initial guidelines

Howto

  • Reviews. The "Reviewers" listed for this PR are the Magma maintainers who will shepherd it.
  • Checks. All required CI checks must pass before merge.
  • Merge. Once approved and passing CI checks, use the ready2merge label to indicate the maintainers can merge your PR.

More info

Please take a moment to read through the Magma project's

If this is your first Magma PR, also consider reading

@github-actions
Copy link
Contributor

github-actions bot commented Jun 1, 2022 •
edited

feg-workflow

    2 files  203 suites   40s ⏱️
374 tests 374 ✔️ 0 💤 0 ❌
388 runs  388 ✔️ 0 💤 0 ❌

Results for commit eb88c0f.

♻️ This comment has been updated with latest results.

@github-actions
Copy link
Contributor

github-actions bot commented Jun 1, 2022 •
edited

dp-workflow

13 tests   13 ✔️  2m 45s ⏱️
  1 suites    0 💤
  1 files      0 ❌

Results for commit eb88c0f.

♻️ This comment has been updated with latest results.

@github-actions
Copy link
Contributor

github-actions bot commented Jun 1, 2022 •
edited

agw-workflow

615 tests   611 ✔️  3m 44s ⏱️
    2 suites      4 💤
    2 files        0 ❌

Results for commit eb88c0f.

♻️ This comment has been updated with latest results.

pshelar
pshelar reviewed Jun 1, 2022
View reviewed changes
lte/gateway/python/integ_tests/s1aptests/s1ap_utils.py Outdated
@@ -90,6 +90,7 @@ class S1ApUtil(object):
datapath = get_datapath()
SPGW_TABLE = 0
LOCAL_PORT = "LOCAL"
LOCAL_PORT_NON_NAT_IPV6 = 15577
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is for mtr port. we should be using port number of 'patch-port' here.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is the significance of mtr port and patch-port. @pshelar Is there a link where I can read about these two ports? Thanks in advance.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

mtr port is used for monitoring purpose.
patch port is used for traffic forwarding.

@pruthvihebbani
Merge remote-tracking branch 'upstream/master' into additional_ipv6_t…
fa72f4b 
…ests
@pruthvihebbani
Addressed review comments
9b5d5c4 
Signed-off-by: Pruthvi Hebbani <pruthvi.hebbani@radisys.com>
@pruthvihebbani
Resolved merge conflicts
d18f168 
Signed-off-by: Pruthvi Hebbani <pruthvi.hebbani@radisys.com>
rsarwad
rsarwad reviewed Jun 17, 2022
View reviewed changes
Copy link
Contributor

@rsarwad rsarwad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left some comments

lte/gateway/python/integ_tests/s1aptests/test_ipv6_non_nat_ded_bearer_ul_tcp.py Outdated Show resolved Hide resolved
lte/gateway/python/integ_tests/s1aptests/test_ipv4v6_non_nat_ul_tcp.py Outdated Show resolved Hide resolved
lte/gateway/python/integ_tests/s1aptests/test_ipv4v6_non_nat_ul_tcp.py Outdated Show resolved Hide resolved
lte/gateway/python/integ_tests/s1aptests/test_ipv4v6_non_nat_ul_tcp.py Outdated Show resolved Hide resolved
lte/gateway/python/integ_tests/s1aptests/test_ipv4v6_non_nat_ul_tcp.py Outdated Show resolved Hide resolved
lte/gateway/python/integ_tests/s1aptests/test_ipv4v6_non_nat_ul_tcp.py Outdated Show resolved Hide resolved
lte/gateway/python/integ_tests/s1aptests/test_ipv6_non_nat_ded_bearer_ul_tcp.py Outdated Show resolved Hide resolved
lte/gateway/python/integ_tests/s1aptests/test_ipv6_non_nat_ded_bearer_ul_tcp.py Outdated Show resolved Hide resolved
lte/gateway/python/integ_tests/s1aptests/test_ipv6_non_nat_ded_bearer_ul_tcp.py Outdated Show resolved Hide resolved
lte/gateway/python/integ_tests/s1aptests/test_ipv4v6_non_nat_ul_tcp.py Show resolved Hide resolved
@pruthvihebbani pruthvihebbani mentioned this pull request Jun 20, 2022
Merged
@pruthvihebbani
Addressed review comments
bed032f 
Signed-off-by: Pruthvi Hebbani <pruthvi.hebbani@radisys.com>
@pruthvihebbani
Addressed review comment
08ec81e 
Signed-off-by: Pruthvi Hebbani <pruthvi.hebbani@radisys.com>
github-actions[bot]
github-actions bot reviewed Aug 8, 2022
View reviewed changes
lte/gateway/python/integ_tests/s1aptests/test_ipv6_non_nat_ded_bearer_ul_tcp.py
class TestIpv6NonNatDedBearerUlTcp(unittest.TestCase):
"""Integration Test: TestIpv6NonNatDedBearerUlTcp"""

def __init__(self, method_name: str = ...) -> None:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚫 [mypy] reported by reviewdog 🐶
Incompatible default for argument "method_name" (default has type "ellipsis", argument has type "str") [assignment]

lte/gateway/python/integ_tests/s1aptests/test_ipv4v6_non_nat_ul_tcp.py
class TestIpv4v6NonNatUlTcp(unittest.TestCase):
"""Integration Test: TestIpv4v6NonNatUlTcp"""

def __init__(self, method_name: str = ...) -> None:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚫 [mypy] reported by reviewdog 🐶
Incompatible default for argument "method_name" (default has type "ellipsis", argument has type "str") [assignment]

@pull-request-size pull-request-size bot added size/XL Denotes a Pull Request that changes 500-999 lines. and removed size/L Denotes a Pull Request that changes 100-499 lines. labels Aug 9, 2022
github-actions[bot]
github-actions bot reviewed Aug 9, 2022
View reviewed changes
lte/gateway/python/integ_tests/s1aptests/test_ipv6_non_nat_ded_bearer_dl_tcp.py
class TestIpv6NonNatDedBearerDlTcp(unittest.TestCase):
"""Integration Test: TestIpv6NonNatDedBearerDlTcp"""

def __init__(self, method_name: str = ...) -> None:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚫 [mypy] reported by reviewdog 🐶
Incompatible default for argument "method_name" (default has type "ellipsis", argument has type "str") [assignment]

lte/gateway/python/integ_tests/s1aptests/test_ipv4v6_non_nat_ded_bearer_ul_tcp.py
class TestIpv4v6NonNatDedBearerUlTcp(unittest.TestCase):
"""Integration Test: TestIpv4v6NonNatDedBearerUlTcp"""

def __init__(self, method_name: str = ...) -> None:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚫 [mypy] reported by reviewdog 🐶
Incompatible default for argument "method_name" (default has type "ellipsis", argument has type "str") [assignment]

lte/gateway/python/integ_tests/s1aptests/test_ipv4v6_non_nat_ded_bearer_dl_tcp.py
class TestIpv4v6NonNatDedBearerDlTcp(unittest.TestCase):
"""Integration Test: TestIpv4v6NonNatDedBrDlTcp"""

def __init__(self, method_name: str = ...) -> None:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚫 [mypy] reported by reviewdog 🐶
Incompatible default for argument "method_name" (default has type "ellipsis", argument has type "str") [assignment]

@github-actions
Copy link
Contributor

github-actions bot commented Aug 9, 2022 •
edited

Oops! Looks like you failed the Python Format Check.

Howto

♻️ Updated: ✅ The check is passing the Python Format Check after the last commit.

@pruthvihebbani
Adding additional tests
7f9c10e 
Signed-off-by: Pruthvi Hebbani <pruthvi.hebbani@radisys.com>
@pruthvihebbani
Added ipv6 tests under comment
0b9ad6a 
Signed-off-by: Pruthvi Hebbani <pruthvi.hebbani@radisys.com>
@pruthvihebbani
Fixed python formatting error
b5f864b 
Signed-off-by: Pruthvi Hebbani <pruthvi.hebbani@radisys.com>
@pruthvihebbani
Fixed python formatting error
0abedd7 
Signed-off-by: Pruthvi Hebbani <pruthvi.hebbani@radisys.com>
VinashakAnkitAman
VinashakAnkitAman reviewed Aug 10, 2022
View reviewed changes
Copy link
Member

@VinashakAnkitAman VinashakAnkitAman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left some comments

@pruthvihebbani
Addressed review comments
1273763 
Signed-off-by: Pruthvi Hebbani <pruthvi.hebbani@radisys.com>
VinashakAnkitAman
VinashakAnkitAman requested changes Aug 10, 2022
View reviewed changes
Copy link
Member

@VinashakAnkitAman VinashakAnkitAman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left some minor comments

@pruthvihebbani
Addressed review comments
ff15da4 
Signed-off-by: Pruthvi Hebbani <pruthvi.hebbani@radisys.com>
@pruthvihebbani
Addressed review comments
5b2730e 
Signed-off-by: Pruthvi Hebbani <pruthvi.hebbani@radisys.com>
@pruthvihebbani
Reverted tests added in defs.mk
eb88c0f 
Signed-off-by: Pruthvi Hebbani <pruthvi.hebbani@radisys.com>
VinashakAnkitAman
VinashakAnkitAman approved these changes Aug 11, 2022
View reviewed changes
Copy link
Member

@VinashakAnkitAman VinashakAnkitAman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

pshelar
pshelar approved these changes Aug 11, 2022
View reviewed changes
Copy link
Contributor

@pshelar pshelar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for finishing it.

@pshelar pshelar merged commit 94176f4 into magma:master Aug 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@geetikabatra geetikabatra geetikabatra left review comments

@rsarwad rsarwad rsarwad left review comments

@github-actions github-actions[bot] github-actions left review comments

@pshelar pshelar pshelar approved these changes

@VinashakAnkitAman VinashakAnkitAman VinashakAnkitAman approved these changes

Assignees
No one assigned
Labels
component: agw Access gateway-related issue size/XL Denotes a Pull Request that changes 500-999 lines.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@pruthvihebbani @pshelar @geetikabatra @rsarwad @VinashakAnkitAman