Revert "feat(agw): IPv6 data path support (#11926)"

[nstng]

This reverts commit 2eae88c.

Summary

looks like #11926 breaks the master build-all workflow - see https://github.com/magma/magma/runs/6704655581?check_suite_focus=true

Should #11926 be reverted for now?

Test Plan

Additional Information

• This change is backwards-breaking

[github-actions]

Thanks for opening a PR! 💯

A couple initial guidelines

• All commits must be signed off. This is enforced by DCO check.
• All PR titles must follow the semantic commits format. This is enforced by Semantic PR.

Howto

• Reviews. The "Reviewers" listed for this PR are the Magma maintainers who will shepherd it.
• Checks. All required CI checks must pass before merge.
• Merge. Once approved and passing CI checks, use the ready2merge label to indicate the maintainers can merge your PR.

More info

Please take a moment to read through the Magma project's

• Contributing Conventions for norms around contributed code

If this is your first Magma PR, also consider reading

• Developer Onboarding for onboarding as a new Magma developer
• Development Workflow for guidance on your first pull request
• CI Checks for points of contact for failing or flaky CI checks
• GitHub-to-Slack mappings for Magma maintainers for guidance on how to contact maintainers on Slack

[github-actions]

feg-workflow

    2 files  202 suites   38s ⏱️
371 tests 371 ✔️ 0 💤 0 ❌
385 runs  385 ✔️ 0 💤 0 ❌

Results for commit fa3c855.

[github-actions]

dp-workflow

  2 files    2 suites   3m 14s ⏱️
15 tests 15 ✔️ 0 💤 0 ❌

Results for commit fa3c855.

[sebathomas]

Looks like the job was green in the PR of #11926. Is it because it wasn't rebased?

[nstng]

Looks like the job was green in the PR of #11926. Is it because it wasn't rebased?

In build_all.yml the job agw-build is guared by github.repository_owner == 'magma'. It is only executed on master. (I assume it would be executed if a branch is created in magma and not on a fork.)

[ssanadhya]

Let's fix CI before merging this

[ssanadhya]

@pruthvihebbani , could you please look into this failure https://github.com/magma/magma/runs/6704655581?check_suite_focus=true from PR #11926 ? Specifically:

==> magma: Clearing any previously set network interfaces...
The IP address configured for the host-only network is not within the
allowed ranges. Please update the address used to be within the allowed
ranges and run the command again.
  Address: 3001::10
  Ranges: 192.168.0.0/16
Valid ranges can be modified in the /etc/vbox/networks.conf file. For
more information including valid format see:
 [ https://www.virtualbox.org/manual/ch06.html#network_hoston](https://www.virtualbox.org/manual/ch06.html#network_hostonly)

Did vagrant destroy magma and vagrant up magma work in your local setup? Did you have to modify /etc/vbox/networks.conf on your host machine before creating the new VM?

[pruthvihebbani]

Yes I have destroyed multiple times in my local setup without making any other changes. It has always worked.

[ssanadhya]

Yes I have destroyed multiple times in my local setup without making any other changes. It has always worked.

@sebathomas , can you help debug this build failure? @pruthvihebbani needs to add Ipv6 network interfaces to magma_dev VM as part of #11926, by modifying the Vagrantfile. This is working in her local setup but not in CI.

[nstng]

@pruthvihebbani This can be reproduced locally with a newer virtualbox version. For me it failed with 6.1.34 and did not fail with 6.1.26. See https://stackoverflow.com/questions/70704093/the-ip-address-configured-for-the-host-only-network-is-not-within-the-allowed-ra. In the workflow files I checked this is setup for ipv4 in a step "Open up network interfaces for VM". I assume this needs be adapted for your ipv6 ip. Also iirc this is part of the gettin started documentation and should be adapted there too.

[pruthvihebbani]

I upgraded vbox to version 6.1.34. I am still not able to reproduce the error. On my local Ubuntu 18.04 host I am able to successfully bringup magma_dev vm after destroying and also able to execute ipv6 data test. Does this mean this error is specific to macOS?

[sebathomas]

That's strange. Maybe you already have an entry in /etc/vbox/networks.conf in your local system?

[nstng]

Does this mean this error is specific to macOS?

I was able to reproduce it on Ubuntu 20.04 (and @jheidbrink on nixos).

[pruthvihebbani]

In my local system /etc/vbox/ folder is empty. I dont have networks.conf this file at all.

[pruthvihebbani]

Does this mean this error is specific to macOS?

I was able to reproduce it on Ubuntu 20.04 (and @jheidbrink on nixos).

Can you share the contents of /etc/vbox/networks.conf file? I will create it in my local system and check if I can recreate the issue

[nstng]

just for the record: discussion continued offline