Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ci): bump cwag images to focal and adapt package setup #12901

Merged
merged 1 commit into from Jun 6, 2022

Conversation

nstng
Copy link
Contributor

@nstng nstng commented Jun 2, 2022

Signed-off-by: Nils Semmelrock nils.semmelrock@tngtech.com

Summary

see #12898 - (partly in pairing with @jheidbrink)

Test Plan

  • cwf/gateway$ vagrant up cwag
  • cwf/gateway$ vagrant up cwag_test

Additional Information

  • This change is backwards-breaking

@nstng nstng requested review from a team and uri200 June 2, 2022 12:40
@pull-request-size pull-request-size bot added the size/S Denotes a PR that changes 10-29 lines. label Jun 2, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Jun 2, 2022

Thanks for opening a PR! 💯

A couple initial guidelines

Howto

  • Reviews. The "Reviewers" listed for this PR are the Magma maintainers who will shepherd it.
  • Checks. All required CI checks must pass before merge.
  • Merge. Once approved and passing CI checks, use the ready2merge label to indicate the maintainers can merge your PR.

More info

Please take a moment to read through the Magma project's

If this is your first Magma PR, also consider reading

@github-actions github-actions bot added component: ci All updates on CI (Jenkins/CircleCi/Github Action) component: cwf labels Jun 2, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Jun 2, 2022

Oops! Looks like you failed the Semantic PR check.

Howto

♻️ Updated: ✅ The check is passing the Semantic PR after the last commit.

Signed-off-by: Nils Semmelrock <nils.semmelrock@tngtech.com>
@nstng nstng changed the title fix(c): bump cwag images to focal and adapt package setup fix(ci): bump cwag images to focal and adapt package setup Jun 2, 2022
@nstng nstng requested a review from tmdzk June 3, 2022 07:20
@nstng
Copy link
Contributor Author

nstng commented Jun 3, 2022

@tim FYI approach for fixing the CWF integ tests

@nstng nstng linked an issue Jun 3, 2022 that may be closed by this pull request
- openssl
- procps
- python-all
- python-twisted-conch
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did the cwf integ tests succeed with this change?

Copy link
Contributor Author

@nstng nstng Jun 3, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

for now I just created the images - its on my list to try them locally (if feasible - if not, then CI might be the better choice here)

@@ -28,10 +28,10 @@
- dh-autoreconf
- libssl-dev
- libtool
- net-tools
Copy link
Contributor

@jheidbrink jheidbrink Jun 3, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just curious: how did you discover this dependency?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

net-tools contains ifconfig - ifconfig is used in one of the ansible steps

@nstng
Copy link
Contributor Author

nstng commented Jun 6, 2022

I did run the tests locally and get
[vagrant@127.0.0.1:2201] out: DONE 4 runs, 44 tests, 11 skipped, 5 failures in 746.922s
I am wondering, if I take a look at green runs before the magmacore artifactory switch I see results like
[vagrant@127.0.0.1:2201] out: DONE 4 runs, 43 tests, 11 skipped, 3 failures in 1165.599s
e.g., https://github.com/magma/magma/runs/6494088763?check_suite_focus=true. What is the goal of these tests? Are the results evaluated somewhere else?

@uri200
Copy link
Contributor

uri200 commented Jun 6, 2022

It looks like TestGyCreditExhaustionRedirect test seems to be flaky.

Once CWAG machine is built, test can be run again individyally using this command

 fab integ_test:provision_vm=False,rerun_fails=0,no_build=True,skip_unit_tests=True,test_result_xml=test.xml,test_re=TestGyCreditExhaustionRedirect

@nstng nstng merged commit 55f4348 into magma:master Jun 6, 2022
crasu pushed a commit to crasu/magma that referenced this pull request Jun 23, 2022
Signed-off-by: Nils Semmelrock <nils.semmelrock@tngtech.com>
crasu pushed a commit to crasu/magma that referenced this pull request Jun 23, 2022
crasu pushed a commit to crasu/magma that referenced this pull request Jun 24, 2022
crasu pushed a commit to crasu/magma that referenced this pull request Jun 27, 2022
emakeev pushed a commit to emakeev/magma that referenced this pull request Aug 5, 2022
Signed-off-by: Nils Semmelrock <nils.semmelrock@tngtech.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: ci All updates on CI (Jenkins/CircleCi/Github Action) component: cwf size/S Denotes a PR that changes 10-29 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Analyse and Fix CWF integ test/cwf-integ-test/Run the integ test
4 participants