fix(ci): the latest package version coincides with the version apt would choose #12909
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…uld choose Signed-off-by: Nils Semmelrock <nils.semmelrock@tngtech.com>
|
Thanks for opening a PR! 💯
Howto
More infoPlease take a moment to read through the Magma project's
If this is your first Magma PR, also consider reading
|
github-actions
bot
added
the
component: ci
|
@tmdzk FYI one issue with the build_all workflow. |
emakeev
pushed a commit
to emakeev/magma
that referenced
this pull request
Aug 5, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Nils Semmelrock nils.semmelrock@tngtech.com
Summary
In pydep at one point for a package
python3-<NAME>it is checked, what is the latest version that could be installed via apt. The latest version is calculated manually via "<"-comparison. This fails e.g., forpython3-webcolorswhen it is available in versions1.5-2.1and1.11.1. The algorithm returns1.5-2.1while apt would install1.11.1as the latest version.Here: do not calculate the latest version manually, but use the existing apt.package.candidate.version mechanics (candidate ^= the candidate of a package that would be installed by apt).
Test Plan
CI - build-all/agw-build/Build AGW
But to be honest, this is hard to reproduce because this relies on certain repository states.
Additional Information