Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(dp): One postgresql instance in dev/CI #12921

Merged
merged 1 commit into from Jun 13, 2022

Conversation

sklgromek
Copy link
Contributor

@sklgromek sklgromek commented Jun 7, 2022

Signed-off-by: Tomasz Gromowski tomasz@freedomfi.com

Summary

Run only one container in postgresql POD, and create databases on-demand on it.
Also deployment should use other db than integration tests

Test plan

  • Run domain-proxy integration-tests with orc8r - cd dp && make orc8r_integration_tests
  • When test-runner-orc8r change state to complete, check it logs kubectl logs test-runner-orc8r

@sklgromek sklgromek requested review from a team and WojSad June 7, 2022 09:43
@pull-request-size pull-request-size bot added the size/L Denotes a Pull Request that changes 100-499 lines. label Jun 7, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Jun 7, 2022

Thanks for opening a PR! 💯

A couple initial guidelines

Howto

  • Reviews. The "Reviewers" listed for this PR are the Magma maintainers who will shepherd it.
  • Checks. All required CI checks must pass before merge.
  • Merge. Once approved and passing CI checks, use the ready2merge label to indicate the maintainers can merge your PR.

More info

Please take a moment to read through the Magma project's

If this is your first Magma PR, also consider reading

@sklgromek sklgromek requested a review from jkmar June 7, 2022 09:43
@github-actions github-actions bot added component: dp All updates to Domain Proxy dp module component: orc8r Orchestrator-related issue labels Jun 7, 2022
@sklgromek sklgromek requested a review from xbend June 7, 2022 09:43
dp/skaffold.yaml Outdated Show resolved Hide resolved
dp/skaffold.yaml Outdated Show resolved Hide resolved
@github-actions
Copy link
Contributor

github-actions bot commented Jun 7, 2022

dp-workflow

18 tests   18 ✔️  4m 16s ⏱️
  2 suites    0 💤
  2 files      0

Results for commit e10f561.

♻️ This comment has been updated with latest results.

@maxhbr
Copy link
Member

maxhbr commented Jun 7, 2022

FYI: The pr description looks incomplete

@sklgromek
Copy link
Contributor Author

FYI: The pr description looks incomplete

I fixed it.

@sklgromek sklgromek requested a review from a team as a code owner June 7, 2022 12:24
@sklgromek sklgromek requested a review from 119Vik June 7, 2022 12:24
@github-actions github-actions bot added the component: ci All updates on CI (Jenkins/CircleCi/Github Action) label Jun 7, 2022
Signed-off-by: Tomasz Gromowski <tomasz@freedomfi.com>
@sklgromek sklgromek requested a review from maxhbr June 9, 2022 09:18
Copy link
Member

@maxhbr maxhbr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sklgromek sklgromek merged commit 69fdf11 into magma:master Jun 13, 2022
@sklgromek sklgromek deleted the dp-one-db-instance branch June 13, 2022 09:39
emakeev pushed a commit to emakeev/magma that referenced this pull request Aug 5, 2022
Signed-off-by: Tomasz Gromowski <tomasz@freedomfi.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: ci All updates on CI (Jenkins/CircleCi/Github Action) component: dp All updates to Domain Proxy dp module component: orc8r Orchestrator-related issue size/L Denotes a Pull Request that changes 100-499 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants