Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Upgrade to echo v4 #12935

Merged
merged 1 commit into from Jun 24, 2022
Merged

chore: Upgrade to echo v4 #12935

merged 1 commit into from Jun 24, 2022

Conversation

jkmar
Copy link
Contributor

@jkmar jkmar commented Jun 8, 2022

Summary

Upgrade echo library from version 3.3.10 to 4.7.2.
This change makes it possible to use some of the additional v4 only libraries,
for example library for collecting http prometheus metrics.

Test Plan

  • Deployment on AWS
  • CI

Signed-off-by: Kuba Marciniszyn kuba@freedomfi.com

@pull-request-size pull-request-size bot added the size/L Denotes a Pull Request that changes 100-499 lines. label Jun 8, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Jun 8, 2022

Thanks for opening a PR! 💯

A couple initial guidelines

Howto

  • Reviews. The "Reviewers" listed for this PR are the Magma maintainers who will shepherd it.
  • Checks. All required CI checks must pass before merge.
  • Merge. Once approved and passing CI checks, use the ready2merge label to indicate the maintainers can merge your PR.

More info

Please take a moment to read through the Magma project's

If this is your first Magma PR, also consider reading

@github-actions github-actions bot added component: cwf component: feg FEG-gateway related issues component: orc8r Orchestrator-related issue labels Jun 8, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Jun 8, 2022

feg-workflow

    2 files  203 suites   37s ⏱️
371 tests 371 ✔️ 0 💤 0
385 runs  385 ✔️ 0 💤 0

Results for commit deaf8d0.

♻️ This comment has been updated with latest results.

@github-actions
Copy link
Contributor

github-actions bot commented Jun 8, 2022

cloud-workflow

982 tests   982 ✔️  2m 15s ⏱️
355 suites      0 💤
    7 files        0

Results for commit deaf8d0.

♻️ This comment has been updated with latest results.

@github-actions
Copy link
Contributor

github-actions bot commented Jun 8, 2022

dp-workflow

18 tests   18 ✔️  4m 45s ⏱️
  2 suites    0 💤
  2 files      0

Results for commit deaf8d0.

♻️ This comment has been updated with latest results.

@github-actions
Copy link
Contributor

github-actions bot commented Jun 8, 2022

agw-workflow

     79 files     124 suites   6m 41s ⏱️
1 153 tests 1 149 ✔️ 4 💤 0
1 155 runs  1 151 ✔️ 4 💤 0

Results for commit deaf8d0.

♻️ This comment has been updated with latest results.

@jkmar jkmar marked this pull request as ready for review June 14, 2022 13:54
@jkmar jkmar requested review from a team, xbend and emakeev June 14, 2022 13:54
Signed-off-by: Kuba Marciniszyn <kuba@freedomfi.com>
@xbend xbend added the ready2merge This PR is ready to be merged (is approved and passes all required checks) label Jun 17, 2022
@jkmar
Copy link
Contributor Author

jkmar commented Jun 20, 2022

Hi @magma/approvers-cwf @magma/approvers-feg @magma/approvers-orc8r could you please review this pr?

Copy link
Member

@maxhbr maxhbr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jkmar
Copy link
Contributor Author

jkmar commented Jun 22, 2022

@magma/approvers-cwf @magma/approvers-feg kind reminder about this pr

@jkmar jkmar merged commit dbbacc5 into magma:master Jun 24, 2022
@jkmar jkmar deleted the upgrade_to_echo_v4 branch June 24, 2022 13:33
emakeev pushed a commit to emakeev/magma that referenced this pull request Aug 5, 2022
Signed-off-by: Kuba Marciniszyn <kuba@freedomfi.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: cwf component: feg FEG-gateway related issues component: orc8r Orchestrator-related issue ready2merge This PR is ready to be merged (is approved and passes all required checks) size/L Denotes a Pull Request that changes 100-499 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants