Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(ci): exclude yarn.lock from misspell #12958

Merged
merged 1 commit into from Jun 10, 2022
Merged

feat(ci): exclude yarn.lock from misspell #12958

merged 1 commit into from Jun 10, 2022

Conversation

Neudrino
Copy link
Contributor

... as it contains packages in British English

@Neudrino
feat(ci): exclude yarn.lock from misspell
66e89b2 
... as it contains packages in British English

Signed-off-by: Fritz Lehnert <13189449+Neudrino@users.noreply.github.com>
@pull-request-size pull-request-size bot added the size/XS Denotes a PR that changes 0-9 lines. label Jun 10, 2022
@github-actions
Copy link
Contributor

Thanks for opening a PR! 💯

A couple initial guidelines

Howto

  • Reviews. The "Reviewers" listed for this PR are the Magma maintainers who will shepherd it.
  • Checks. All required CI checks must pass before merge.
  • Merge. Once approved and passing CI checks, use the ready2merge label to indicate the maintainers can merge your PR.

More info

Please take a moment to read through the Magma project's

If this is your first Magma PR, also consider reading

@github-actions github-actions bot added the component: ci All updates on CI (Jenkins/CircleCi/Github Action) label Jun 10, 2022
@Neudrino Neudrino marked this pull request as ready for review June 10, 2022 11:15
@Neudrino Neudrino requested a review from a team as a code owner June 10, 2022 11:15
@github-actions
Copy link
Contributor

dp-workflow

18 tests   18 ✔️  4m 59s ⏱️
  2 suites    0 💤
  2 files      0 ❌

Results for commit 66e89b2.

maxhbr
maxhbr approved these changes Jun 10, 2022
View reviewed changes
Copy link
Member

@maxhbr maxhbr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Neudrino Neudrino merged commit ff7e19a into magma:master Jun 10, 2022
@Neudrino Neudrino deleted the ci/reviewdog-misspell-excludes branch June 10, 2022 14:27
emakeev pushed a commit to emakeev/magma that referenced this pull request Aug 5, 2022
@Neudrino @emakeev
feat(ci): exclude yarn.lock from misspell (magma#12958)
9d6c547 
... as it contains packages in British English

Signed-off-by: Fritz Lehnert <13189449+Neudrino@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maxhbr maxhbr maxhbr approved these changes

@thmsschmitt thmsschmitt Awaiting requested review from thmsschmitt

@nstng nstng Awaiting requested review from nstng

@jheidbrink jheidbrink Awaiting requested review from jheidbrink

Assignees
No one assigned
Labels
component: ci All updates on CI (Jenkins/CircleCi/Github Action) size/XS Denotes a PR that changes 0-9 lines.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Neudrino @maxhbr