Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(agw): suppressed dual exception message #12961

Conversation

VinashakAnkitAman
Copy link
Member

Title

fix(agw): suppressed dual exception message

Summary

Some of the test cases were throwing unnecessary dual exceptions if timeout occurs while waiting for messages. This PR suppresses the dual exception messages by discarding exception chain

Example of unnecessary dual exception:

test_activate_deactivate_multiplededicated failed (2 runs remaining out of 3).Traceback (most recent call last):
          File "/home/vagrant/magma/lte/gateway/python/integ_tests/s1aptests/s1ap_utils.py", line 218, in get_response
            return self._msg.get(True, timeout)
          File "/usr/lib/python3.5/queue.py", line 172, in get
            raise Empty
        queue.Empty

        During handling of the above exception, another exception occurred:

        Traceback (most recent call last):
          File "/usr/lib/python3.5/unittest/case.py", line 59, in testPartExecutor
            yield
          File "/usr/lib/python3.5/unittest/case.py", line 601, in run
            testMethod()
          File "/home/vagrant/magma/lte/gateway/python/integ_tests/s1aptests/test_activate_deactivate_multiple_dedicated.py", line 114, in test_activate_deactivate_multiplededicated
            response = self._s1ap_wrapper.s1_util.get_response()
          File "/home/vagrant/magma/lte/gateway/python/integ_tests/s1aptests/s1ap_utils.py", line 224, in get_response
            + " sec) occurred while waiting for response message",
        AssertionError: Timeout (180 sec) occurred while waiting for response message

Suppressed excption:

test_activate_deactivate_multiplededicated failed (2 runs remaining out of 3).Traceback (most recent call last):
          File "/usr/lib/python3.5/unittest/case.py", line 59, in testPartExecutor
            yield
          File "/usr/lib/python3.5/unittest/case.py", line 601, in run
            testMethod()
          File "/home/vagrant/magma/lte/gateway/python/integ_tests/s1aptests/test_activate_deactivate_multiple_dedicated.py", line 114, in test_activate_deactivate_multiplededicated
            response = self._s1ap_wrapper.s1_util.get_response()
          File "/home/vagrant/magma/lte/gateway/python/integ_tests/s1aptests/s1ap_utils.py", line 225, in get_response
            ) from None

Test plan

Verified with sanity

Signed-off-by: VinashakAnkitAman ankit.aman@radisys.com

Signed-off-by: VinashakAnkitAman <ankit.aman@radisys.com>
@VinashakAnkitAman VinashakAnkitAman requested review from a team and rsarwad June 10, 2022 14:39
@pull-request-size pull-request-size bot added the size/XS Denotes a PR that changes 0-9 lines. label Jun 10, 2022
@github-actions
Copy link
Contributor

Thanks for opening a PR! 💯

A couple initial guidelines

Howto

  • Reviews. The "Reviewers" listed for this PR are the Magma maintainers who will shepherd it.
  • Checks. All required CI checks must pass before merge.
  • Merge. Once approved and passing CI checks, use the ready2merge label to indicate the maintainers can merge your PR.

More info

Please take a moment to read through the Magma project's

If this is your first Magma PR, also consider reading

@github-actions github-actions bot added the component: agw Access gateway-related issue label Jun 10, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Jun 10, 2022

feg-workflow

    2 files  202 suites   38s ⏱️
371 tests 371 ✔️ 0 💤 0
385 runs  385 ✔️ 0 💤 0

Results for commit 777c348.

♻️ This comment has been updated with latest results.

@github-actions
Copy link
Contributor

github-actions bot commented Jun 10, 2022

dp-workflow

18 tests   18 ✔️  4m 30s ⏱️
  2 suites    0 💤
  2 files      0

Results for commit 777c348.

♻️ This comment has been updated with latest results.

@github-actions
Copy link
Contributor

github-actions bot commented Jun 10, 2022

agw-workflow

     78 files     123 suites   6m 42s ⏱️
1 152 tests 1 148 ✔️ 4 💤 0
1 154 runs  1 150 ✔️ 4 💤 0

Results for commit 777c348.

♻️ This comment has been updated with latest results.

Signed-off-by: VinashakAnkitAman <ankit.aman@radisys.com>
@ardzoht ardzoht merged commit dec2691 into magma:master Jun 13, 2022
emakeev pushed a commit to emakeev/magma that referenced this pull request Aug 5, 2022
Signed-off-by: VinashakAnkitAman <ankit.aman@radisys.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: agw Access gateway-related issue size/XS Denotes a PR that changes 0-9 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants