New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(agw): suppressed dual exception message #12961
Merged
ardzoht
merged 2 commits into
magma:master
from
VinashakAnkitAman:ankit_suppressed_repeat_exception_message
Jun 13, 2022
Merged
fix(agw): suppressed dual exception message #12961
ardzoht
merged 2 commits into
magma:master
from
VinashakAnkitAman:ankit_suppressed_repeat_exception_message
Jun 13, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: VinashakAnkitAman <ankit.aman@radisys.com>
Thanks for opening a PR! 💯
Howto
More infoPlease take a moment to read through the Magma project's
If this is your first Magma PR, also consider reading
|
sebathomas
approved these changes
Jun 10, 2022
Signed-off-by: VinashakAnkitAman <ankit.aman@radisys.com>
ardzoht
approved these changes
Jun 13, 2022
emakeev
pushed a commit
to emakeev/magma
that referenced
this pull request
Aug 5, 2022
Signed-off-by: VinashakAnkitAman <ankit.aman@radisys.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Title
fix(agw): suppressed dual exception message
Summary
Some of the test cases were throwing unnecessary dual exceptions if timeout occurs while waiting for messages. This PR suppresses the dual exception messages by discarding exception chain
Example of unnecessary dual exception:
Suppressed excption:
Test plan
Verified with sanity
Signed-off-by: VinashakAnkitAman ankit.aman@radisys.com