Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ci): Fix bazel remote cache config for bazel version 5 #12971

Merged
merged 1 commit into from Jun 13, 2022

Conversation

LKreutzer
Copy link
Contributor

@LKreutzer LKreutzer commented Jun 13, 2022

Signed-off-by: Lars Kreutzer lars.kreutzer@tngtech.com

Summary

  • In bazel 5 the disk and repository cache configs (in config:docker) clash with the remote cache config and the PUT requests to the remote cache are not processed properly.
    • The disk and repository cache configs are disabled for the bazel base container.

Test Plan

CI

Additional Information

  • This change is backwards-breaking

@LKreutzer LKreutzer added the bazel changes for the Bazelification effort label Jun 13, 2022
@pull-request-size pull-request-size bot added the size/XS Denotes a PR that changes 0-9 lines. label Jun 13, 2022
@github-actions
Copy link
Contributor

Thanks for opening a PR! 💯

A couple initial guidelines

Howto

  • Reviews. The "Reviewers" listed for this PR are the Magma maintainers who will shepherd it.
  • Checks. All required CI checks must pass before merge.
  • Merge. Once approved and passing CI checks, use the ready2merge label to indicate the maintainers can merge your PR.

More info

Please take a moment to read through the Magma project's

If this is your first Magma PR, also consider reading

Signed-off-by: Lars Kreutzer <lars.kreutzer@tngtech.com>
@LKreutzer LKreutzer force-pushed the fix_ci_bazel_remote_cache_config branch from 1900a0f to 4310ca2 Compare June 13, 2022 11:45
@LKreutzer LKreutzer added the component: ci All updates on CI (Jenkins/CircleCi/Github Action) label Jun 13, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Jun 13, 2022

agw-workflow

     78 files     123 suites   6m 50s ⏱️
1 152 tests 1 148 ✔️ 4 💤 0
1 154 runs  1 150 ✔️ 4 💤 0

Results for commit 4310ca2.

♻️ This comment has been updated with latest results.

@LKreutzer LKreutzer marked this pull request as ready for review June 13, 2022 14:02
@LKreutzer LKreutzer requested review from a team and vktng June 13, 2022 14:02
@@ -1 +1 @@
common --config=docker
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change is required because the bazel query in the test job otherwise uses an empty config which leads to an error.

@nstng nstng requested review from nstng and removed request for vktng June 13, 2022 14:13
Copy link
Contributor

@nstng nstng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm - in pairing

@nstng nstng merged commit afe8d70 into magma:master Jun 13, 2022
emakeev pushed a commit to emakeev/magma that referenced this pull request Aug 5, 2022
Signed-off-by: Lars Kreutzer <lars.kreutzer@tngtech.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bazel changes for the Bazelification effort component: ci All updates on CI (Jenkins/CircleCi/Github Action) size/XS Denotes a PR that changes 0-9 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants