Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(orc8r): Remove temporary go.mod files #12993

Merged
merged 1 commit into from Jun 15, 2022

Conversation

MoritzThomasHuebner
Copy link
Contributor

Summary

These files appear to be committed by mistake a long time ago. A simple grep shows that they are not used anywhere in the project. We should thus remove them again.

Test Plan

  • Searched for file names in within magma to assure those are not used anywhere
  • Run unit tests to assure nothing is broken

Additional Information

  • This change is backwards-breaking

These files appear to be committed by mistake a long time ago. A simple grep shows that they are not used anywhere in the project. We should thus remove them again.

Signed-off-by: Moritz Huebner <moritz.huebner@tngtech.com>
@pull-request-size pull-request-size bot added the size/XS Denotes a PR that changes 0-9 lines. label Jun 15, 2022
@github-actions github-actions bot added the component: orc8r Orchestrator-related issue label Jun 15, 2022
@github-actions
Copy link
Contributor

Thanks for opening a PR! 💯

A couple initial guidelines

Howto

  • Reviews. The "Reviewers" listed for this PR are the Magma maintainers who will shepherd it.
  • Checks. All required CI checks must pass before merge.
  • Merge. Once approved and passing CI checks, use the ready2merge label to indicate the maintainers can merge your PR.

More info

Please take a moment to read through the Magma project's

If this is your first Magma PR, also consider reading

@MoritzThomasHuebner MoritzThomasHuebner marked this pull request as ready for review June 15, 2022 01:55
@MoritzThomasHuebner MoritzThomasHuebner requested review from a team and uri200 June 15, 2022 01:55
@MoritzThomasHuebner MoritzThomasHuebner changed the title chore(orc8r): Removes temporary go.mod files chore(orc8r): Remove temporary go.mod files Jun 15, 2022
@voisey voisey requested review from sebathomas and removed request for uri200 June 15, 2022 08:20
@sebathomas sebathomas merged commit b964902 into master Jun 15, 2022
@sebathomas sebathomas deleted the Remove_temporary_go_mod_files branch June 15, 2022 09:45
emakeev pushed a commit to emakeev/magma that referenced this pull request Aug 5, 2022
These files appear to be committed by mistake a long time ago. A simple grep shows that they are not used anywhere in the project. We should thus remove them again.

Signed-off-by: Moritz Huebner <moritz.huebner@tngtech.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: orc8r Orchestrator-related issue size/XS Denotes a PR that changes 0-9 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants